-
Notifications
You must be signed in to change notification settings - Fork 858
Expand file tree
/
Copy pathAsyncMemoize.fs
More file actions
580 lines (423 loc) · 17.8 KB
/
AsyncMemoize.fs
File metadata and controls
580 lines (423 loc) · 17.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
module CompilerService.AsyncMemoize
open System
open System.Threading
open Xunit
open Internal.Utilities.Collections
open System.Threading.Tasks
open System.Diagnostics
open System.Collections.Concurrent
open FSharp.Compiler.DiagnosticsLogger
open FSharp.Compiler.Diagnostics
open FSharp.Compiler.BuildGraph
let timeout = TimeSpan.FromSeconds 10.
let waitFor (mre: ManualResetEvent) =
if not <| mre.WaitOne timeout then
failwith "waitFor timed out"
let waitUntil condition value =
task {
let sw = Stopwatch.StartNew()
while not <| condition value do
if sw.Elapsed > timeout then
failwith "waitUntil timed out"
do! Task.Delay 10
}
let rec internal spinFor (duration: TimeSpan) =
async {
let sw = Stopwatch.StartNew()
do! Async.Sleep 10
let remaining = duration - sw.Elapsed
if remaining > TimeSpan.Zero then
return! spinFor remaining
}
type internal EventRecorder<'a, 'b, 'c when 'a : equality and 'b : equality>(memoize: AsyncMemoize<'a,'b,'c>) as self =
let events = ConcurrentQueue()
do memoize.OnEvent self.Add
member _.Add (e, (_label, k, _version)) = events.Enqueue (e, k)
member _.Received value = events |> Seq.exists (fst >> (=) value)
member _.CountOf value count = events |> Seq.filter (fst >> (=) value) |> Seq.length |> (=) count
member _.ShouldBe (expected) =
let expected = expected |> Seq.toArray
let actual = events |> Seq.toArray
Assert.Equal<_ array>(expected, actual)
member _.Sequence = events |> Seq.map id
[<Fact>]
let ``Basics``() =
let computation key = async {
do! Async.Sleep 1
return key * 2
}
let memoize = AsyncMemoize<int, int, int>()
let events = EventRecorder(memoize)
let result =
seq {
memoize.Get'(5, computation 5)
memoize.Get'(5, computation 5)
memoize.Get'(2, computation 2)
memoize.Get'(5, computation 5)
memoize.Get'(3, computation 3)
memoize.Get'(2, computation 2)
}
|> Async.Parallel
|> Async.RunSynchronously
let expected = [| 10; 10; 4; 10; 6; 4|]
Assert.Equal<int array>(expected, result)
(waitUntil (events.CountOf Finished) 3).Wait()
let groups = events.Sequence |> Seq.groupBy snd |> Seq.toList
Assert.Equal(3, groups.Length)
for key, events in groups do
Assert.Equal<Set<(JobEvent * int)>>(Set [ Requested, key; Started, key; Finished, key ], Set events)
[<Fact>]
let ``We can cancel a job`` () =
task {
let jobStarted = new ManualResetEvent(false)
let computation action = async {
action() |> ignore
do! spinFor timeout
failwith "Should be canceled before it gets here"
}
let memoize = AsyncMemoize<_, int, _>()
let events = EventRecorder(memoize)
use cts1 = new CancellationTokenSource()
use cts2 = new CancellationTokenSource()
use cts3 = new CancellationTokenSource()
let key = 1
let _task1 = Async.StartAsTask( memoize.Get'(key, computation jobStarted.Set), cancellationToken = cts1.Token)
waitFor jobStarted
jobStarted.Reset() |> ignore
let _task2 = Async.StartAsTask( memoize.Get'(key, computation ignore), cancellationToken = cts2.Token)
let _task3 = Async.StartAsTask( memoize.Get'(key, computation ignore), cancellationToken = cts3.Token)
do! waitUntil (events.CountOf Requested) 3
cts1.Cancel()
cts2.Cancel()
waitFor jobStarted
cts3.Cancel()
do! waitUntil events.Received Canceled
events.ShouldBe [
Requested, key
Started, key
Requested, key
Requested, key
Restarted, key
Canceled, key
]
}
[<Fact>]
let ``Job is restarted if first requestor cancels`` () =
task {
let jobStarted = new ManualResetEvent(false)
let jobCanComplete = new ManualResetEvent(false)
let computation key = async {
jobStarted.Set() |> ignore
waitFor jobCanComplete
return key * 2
}
let memoize = AsyncMemoize<_, int, _>()
let events = EventRecorder(memoize)
use cts1 = new CancellationTokenSource()
use cts2 = new CancellationTokenSource()
use cts3 = new CancellationTokenSource()
let key = 1
let _task1 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts1.Token)
waitFor jobStarted
jobStarted.Reset() |> ignore
let _task2 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts2.Token)
let _task3 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts3.Token)
do! waitUntil (events.CountOf Requested) 3
cts1.Cancel()
waitFor jobStarted
jobCanComplete.Set() |> ignore
let! result = _task2
Assert.Equal(2, result)
events.ShouldBe [
Requested, key
Started, key
Requested, key
Requested, key
Restarted, key
Finished, key ]
}
[<Fact>]
let ``Job is restarted if first requestor cancels but keeps running if second requestor cancels`` () =
task {
let jobStarted = new ManualResetEvent(false)
let jobCanComplete = new ManualResetEvent(false)
let computation key = async {
jobStarted.Set() |> ignore
waitFor jobCanComplete
return key * 2
}
let memoize = AsyncMemoize<_, int, _>()
let events = EventRecorder(memoize)
use cts1 = new CancellationTokenSource()
use cts2 = new CancellationTokenSource()
use cts3 = new CancellationTokenSource()
let key = 1
let _task1 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts1.Token)
waitFor jobStarted
jobStarted.Reset() |> ignore
let _task2 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts2.Token)
let _task3 = Async.StartAsTask( memoize.Get'(key, computation key), cancellationToken = cts3.Token)
do! waitUntil (events.CountOf Requested) 3
cts1.Cancel()
waitFor jobStarted
cts2.Cancel()
jobCanComplete.Set() |> ignore
let! result = _task3
Assert.Equal(2, result)
events.ShouldBe [
Requested, key
Started, key
Requested, key
Requested, key
Restarted, key
Finished, key ]
}
type ExpectedException() =
inherit Exception()
[<Fact(Skip="Flaky")>]
let ``Stress test`` () =
let seed = System.Random().Next()
let rng = System.Random seed
let threads = 30
let iterations = 30
let maxDuration = 100
let minTimeout = 0
let maxTimeout = 500
let exceptionProbability = 0.01
let gcProbability = 0.1
let stepMs = 10
let keyCount = rng.Next(5, 200)
let keys = [| 1 .. keyCount |]
let testTimeoutMs = threads * iterations * maxDuration * 2
let intenseComputation durationMs result =
async {
if rng.NextDouble() < exceptionProbability then
raise (ExpectedException())
let s = Stopwatch.StartNew()
let mutable number = 0
while (int s.ElapsedMilliseconds) < durationMs do
number <- number + 1 % 12345
return [result]
}
let rec sleepyComputation durationMs result =
async {
if rng.NextDouble() < (exceptionProbability / (float durationMs / float stepMs)) then
raise (ExpectedException())
if durationMs > 0 then
do! Async.Sleep (min stepMs durationMs)
return! sleepyComputation (durationMs - stepMs) result
else
return [result]
}
let rec mixedComputation durationMs result =
async {
if durationMs > 0 then
if rng.NextDouble() < 0.5 then
let! _ = intenseComputation (min stepMs durationMs) ()
()
else
let! _ = sleepyComputation (min stepMs durationMs) ()
()
return! mixedComputation (durationMs - stepMs) result
else
return [result]
}
let computations = [|
intenseComputation
sleepyComputation
mixedComputation
|]
let cache = AsyncMemoize<int, int, int list>(keepStrongly=5, keepWeakly=10)
let mutable started = 0
let mutable canceled = 0
let mutable timeout = 0
let mutable failed = 0
let mutable completed = 0
let test =
seq {
for _ in 1..threads do
let rec loop iteration =
task {
if gcProbability > rng.NextDouble() then
GC.Collect(2, GCCollectionMode.Forced, false)
let computation = computations[rng.Next computations.Length]
let durationMs = rng.Next maxDuration
let timeoutMs = rng.Next(minTimeout, maxTimeout)
let key = keys[rng.Next keys.Length]
let result = key * 2
let job = cache.Get'(key, computation durationMs result)
let cts = new CancellationTokenSource()
let runningJob = Async.StartAsTask(job, cancellationToken = cts.Token)
cts.CancelAfter timeoutMs
Interlocked.Increment &started |> ignore
try
let! actual = runningJob
Assert.Equal(result, actual.Head)
Interlocked.Increment &completed |> ignore
with
| :? TaskCanceledException as _e ->
Interlocked.Increment &canceled |> ignore
| :? OperationCanceledException as _e ->
Interlocked.Increment &canceled |> ignore
| :? TimeoutException -> Interlocked.Increment &timeout |> ignore
| :? ExpectedException -> Interlocked.Increment &failed |> ignore
| :? AggregateException as ex when
ex.Flatten().InnerExceptions |> Seq.exists (fun e -> e :? ExpectedException) ->
Interlocked.Increment &failed |> ignore
| e ->
failwith $"Seed {seed} failed on iteration {iteration}: %A{e}"
if iteration < iterations then
return! loop (iteration + 1)
return ()
}
loop 1
}
|> Task.WhenAll
if not (test.Wait testTimeoutMs) then failwith "Test timed out - most likely deadlocked"
Assert.Equal (threads * iterations, started)
// Assert.Equal<int * int * int * int * int>((0,0,0,0,0),(started, completed, canceled, failed, timeout))
Assert.Equal (started, completed + canceled + failed + timeout)
Assert.True ((float completed) > ((float started) * 0.1), "Less than 10 % completed jobs")
[<Theory>]
[<InlineData(true, 1)>]
[<InlineData(false, 2)>]
let ``Cancel running jobs with the same key`` cancelDuplicate expectFinished =
task {
let cache = AsyncMemoize(cancelDuplicateRunningJobs=cancelDuplicate)
let mutable started = 0
let mutable finished = 0
let job1started = new ManualResetEvent(false)
let job1finished = new ManualResetEvent(false)
let jobCanContinue = new ManualResetEvent(false)
let job2started = new ManualResetEvent(false)
let job2finished = new ManualResetEvent(false)
let work onStart onFinish = async {
Interlocked.Increment &started |> ignore
onStart() |> ignore
waitFor jobCanContinue
do! spinFor (TimeSpan.FromMilliseconds 100)
Interlocked.Increment &finished |> ignore
onFinish() |> ignore
}
let key1 =
{ new ICacheKey<_, _> with
member _.GetKey() = 1
member _.GetVersion() = 1
member _.GetLabel() = "key1" }
cache.Get(key1, work job1started.Set job1finished.Set) |> Async.Start
waitFor job1started
let key2 =
{ new ICacheKey<_, _> with
member _.GetKey() = key1.GetKey()
member _.GetVersion() = key1.GetVersion() + 1
member _.GetLabel() = "key2" }
cache.Get(key2, work job2started.Set job2finished.Set ) |> Async.Start
waitFor job2started
jobCanContinue.Set() |> ignore
waitFor job2finished
if not cancelDuplicate then
waitFor job1finished
Assert.Equal((2, expectFinished), (started, finished))
}
type DummyException(msg) =
inherit Exception(msg)
[<Fact>]
let ``Preserve thread static diagnostics`` () =
let seed = System.Random().Next()
let rng = System.Random seed
let job1Cache = AsyncMemoize()
let job2Cache = AsyncMemoize()
let job1 (input: string) = async {
let! _ = Async.Sleep (rng.Next(1, 30))
let ex = DummyException("job1 error")
DiagnosticsThreadStatics.DiagnosticsLogger.ErrorR(ex)
return Ok input
}
let job2 (input: int) = async {
DiagnosticsThreadStatics.DiagnosticsLogger.Warning(DummyException("job2 error 1"))
let! _ = Async.Sleep (rng.Next(1, 30))
let key = { new ICacheKey<_, _> with
member _.GetKey() = "job1"
member _.GetVersion() = input
member _.GetLabel() = "job1" }
let! result = job1Cache.Get(key, job1 "${input}" )
DiagnosticsThreadStatics.DiagnosticsLogger.Warning(DummyException("job2 error 2"))
return input, result
}
let tasks = seq {
for i in 1 .. 100 do
task {
let diagnosticsLogger =
CompilationDiagnosticLogger($"Testing task {i}", FSharpDiagnosticOptions.Default)
use _ = new CompilationGlobalsScope(diagnosticsLogger, BuildPhase.Optimize)
DiagnosticsThreadStatics.DiagnosticsLogger.Warning(DummyException("task error"))
let key = { new ICacheKey<_, _> with
member _.GetKey() = "job2"
member _.GetVersion() = rng.Next(1, 10)
member _.GetLabel() = "job2" }
let! result = job2Cache.Get(key, job2 (i % 10))
let diagnostics = diagnosticsLogger.GetDiagnostics()
//Assert.Equal(3, diagnostics.Length)
return result, diagnostics
}
}
let results = (Task.WhenAll tasks).Result
let _diagnosticCounts = results |> Seq.map snd |> Seq.map Array.length |> Seq.groupBy id |> Seq.map (fun (k, v) -> k, v |> Seq.length) |> Seq.sortBy fst |> Seq.toList
//Assert.Equal<(int * int) list>([4, 100], diagnosticCounts)
let diagnosticMessages = results |> Seq.map snd |> Seq.map (Array.map (fun (d, _) -> d.Exception.Message) >> Array.toList) |> Set
Assert.Equal<Set<_>>(Set [["task error"; "job2 error 1"; "job1 error"; "job2 error 2"; ]], diagnosticMessages)
[<Fact>]
let ``Preserve thread static diagnostics already completed job`` () =
let cache = AsyncMemoize()
let key = { new ICacheKey<_, _> with
member _.GetKey() = "job1"
member _.GetVersion() = 1
member _.GetLabel() = "job1" }
let job (input: string) = async {
let ex = DummyException($"job {input} error")
DiagnosticsThreadStatics.DiagnosticsLogger.ErrorR(ex)
return Ok input
}
async {
let diagnosticsLogger = CompilationDiagnosticLogger($"Testing", FSharpDiagnosticOptions.Default)
use _ = new CompilationGlobalsScope(diagnosticsLogger, BuildPhase.Optimize)
let! _ = cache.Get(key, job "1" )
let! _ = cache.Get(key, job "2" )
let diagnosticMessages = diagnosticsLogger.GetDiagnostics() |> Array.map (fun (d, _) -> d.Exception.Message) |> Array.toList
Assert.Equal<list<_>>(["job 1 error"; "job 1 error"], diagnosticMessages)
}
|> Async.StartAsTask
[<Fact>]
let ``We get diagnostics from the job that failed`` () =
let cache = AsyncMemoize()
let key = { new ICacheKey<_, _> with
member _.GetKey() = "job1"
member _.GetVersion() = 1
member _.GetLabel() = "job1" }
let job (input: int) = async {
let ex = DummyException($"job {input} error")
do! Async.Sleep 100
DiagnosticsThreadStatics.DiagnosticsLogger.Error(ex)
return 5
}
let result =
[1; 2]
|> Seq.map (fun i ->
async {
let diagnosticsLogger = CompilationDiagnosticLogger($"Testing", FSharpDiagnosticOptions.Default)
use _ = new CompilationGlobalsScope(diagnosticsLogger, BuildPhase.Optimize)
try
let! _ = cache.Get(key, job i )
()
with _ ->
()
let diagnosticMessages = diagnosticsLogger.GetDiagnostics() |> Array.map (fun (d, _) -> d.Exception.Message) |> Array.toList
return diagnosticMessages
})
|> Async.Parallel
|> Async.StartAsTask
|> (fun t -> t.Result)
|> Array.toList
Assert.True(
result = [["job 1 error"]; ["job 1 error"]] ||
result = [["job 2 error"]; ["job 2 error"]] )