Don't throw PendingModelChangesWarning when applying a specific migration

Fixes #35342

Author: AndriySvyryd

src/EFCore.Relational/Migrations/Internal/Migrator.cs

@@ -94,7 +94,7 @@ public Migrator(
     public virtual void Migrate(string? targetMigration)
     {
         var useTransaction = _connection.CurrentTransaction is null;
-        ValidateMigrations(useTransaction);
+        ValidateMigrations(useTransaction, targetMigration);
 
         using var transactionScope = new TransactionScope(TransactionScopeOption.Suppress, TransactionScopeAsyncFlowOption.Enabled);
 
@@ -219,7 +219,7 @@ public virtual async Task MigrateAsync(
         CancellationToken cancellationToken = default)
     {
         var useTransaction = _connection.CurrentTransaction is null;
-        ValidateMigrations(useTransaction);
+        ValidateMigrations(useTransaction, targetMigration);
 
         using var transactionScope = new TransactionScope(TransactionScopeOption.Suppress, TransactionScopeAsyncFlowOption.Enabled);
 
@@ -349,7 +349,7 @@ await _migrationCommandExecutor.ExecuteNonQueryAsync(
         }
     }
 
-    private void ValidateMigrations(bool useTransaction)
+    private void ValidateMigrations(bool useTransaction, string? targetMigration)
     {
         if (!useTransaction
             && _executionStrategy.RetriesOnFailure)
@@ -365,7 +365,8 @@ private void ValidateMigrations(bool useTransaction)
         {
             _logger.ModelSnapshotNotFound(this, _migrationsAssembly);
         }
-        else if (RelationalResources.LogPendingModelChanges(_logger).WarningBehavior != WarningBehavior.Ignore
+        else if (targetMigration == null
+            && RelationalResources.LogPendingModelChanges(_logger).WarningBehavior != WarningBehavior.Ignore
             && HasPendingModelChanges())
         {
             var modelSource = (ModelSource)_currentContext.Context.GetService<IModelSource>();

test/EFCore.Specification.Tests/DataBindingTestBase.cs

@@ -281,32 +281,32 @@ public virtual void Remove_detached_entity_from_LocalView(bool toObservableColle
         Assert.Equal(2, local.ToList().Count);
 
         Assert.True(local.Contains(driver1));
-        Assert.True(localView.Contains(driver1));
+        Assert.Contains(driver1, localView);
         Assert.True(local.Contains(driver2));
-        Assert.True(localView.Contains(driver2));
+        Assert.Contains(driver2, localView);
         Assert.False(local.Contains(driver3));
-        Assert.False(localView.Contains(driver3));
+        Assert.DoesNotContain(driver3, localView);
 
         context.Entry(driver3);
 
         Assert.True(local.Contains(driver1));
-        Assert.True(localView.Contains(driver1));
+        Assert.Contains(driver1, localView);
         Assert.True(local.Contains(driver2));
-        Assert.True(localView.Contains(driver2));
+        Assert.Contains(driver2, localView);
         Assert.False(local.Contains(driver3));
-        Assert.False(localView.Contains(driver3));
+        Assert.DoesNotContain(driver3, localView);
 
         local.Remove(driver3);
 
         Assert.Equal(2, local.Count);
         Assert.Equal(2, local.ToList().Count);
 
         Assert.True(local.Contains(driver1));
-        Assert.True(localView.Contains(driver1));
+        Assert.Contains(driver1, localView);
         Assert.True(local.Contains(driver2));
-        Assert.True(localView.Contains(driver2));
+        Assert.Contains(driver2, localView);
         Assert.False(local.Contains(driver3));
-        Assert.False(localView.Contains(driver3));
+        Assert.DoesNotContain(driver3, localView);
     }
 
     [ConditionalTheory]

test/EFCore.SqlServer.FunctionalTests/Migrations/MigrationsInfrastructureSqlServerTest.cs

@@ -807,8 +807,7 @@ public async Task Empty_Migration_Creates_Database()
         {
             using var context = new BloggingContext(
                 Fixture.TestStore.AddProviderOptions(
-                        new DbContextOptionsBuilder().EnableServiceProviderCaching(false))
-                    .ConfigureWarnings(e => e.Log(RelationalEventId.PendingModelChangesWarning)).Options);
+                        new DbContextOptionsBuilder().EnableServiceProviderCaching(false)).Options);
 
             context.Database.EnsureDeleted();
             GiveMeSomeTime(context);

test/EFCore.SqlServer.FunctionalTests/Query/JsonQueryJsonTypeSqlServerFixture.cs

@@ -26,7 +26,6 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con
             b =>
             {
                 b.OwnsOne(x => x.OwnedReferenceRoot).ToJson("json_reference_custom_naming").HasColumnType("json");
-                ;
                 b.OwnsMany(x => x.OwnedCollectionRoot).HasColumnType("json").ToJson("json_collection_custom_naming");
             });