Skip to content

Conversation

@radical
Copy link
Member

@radical radical commented Aug 16, 2024

  • And Skip playground apps that have specific tests from AppHostRunsCleanlyForAppsWithNoOtherTests
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 16, 2024
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-integrations Issues pertaining to Aspire Integrations packages labels Aug 16, 2024
@radical
Copy link
Member Author

radical commented Aug 16, 2024

Depends on #5318 .

@radical radical mentioned this pull request Aug 16, 2024
35 tasks
@radical
Copy link
Member Author

radical commented Aug 16, 2024

Failing with this:

Unhandled exception. System.UnauthorizedAccessException: Access to the path '/Eventhubs_Emulator/ConfigFiles/Config.json' is denied.
 ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func`4 createOpenException)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at Microsoft.Extensions.Configuration.FileConfigurationProvider.<Load>g__OpenRead|6_0(IFileInfo fileInfo)
   at Microsoft.Extensions.Configuration.FileConfigurationProvider.Load(Boolean reload)
   at Microsoft.Extensions.Configuration.ConfigurationRoot..ctor(IList`1 providers)
   at Microsoft.Extensions.Configuration.ConfigurationBuilder.Build()
   at Microsoft.Extensions.Hosting.HostBuilder.InitializeAppConfiguration()
   at Microsoft.Extensions.Hosting.HostBuilder.Build()
   at a.a.aaR.A(String[])
   at a.a.aaR.<Main>(String[])

The file is bind-mount'ed, and writing to it, or trying to create that directory fails on linux.

@radical
Copy link
Member Author

radical commented Aug 16, 2024

Blocked on #5326 .

@radical
Copy link
Member Author

radical commented Aug 21, 2024

Blocked on #5371 .

@davidfowl
Copy link
Member

/azp run

@davidfowl
Copy link
Member

This should be unblocked

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical force-pushed the eventhub-playground-test branch from 5a8a987 to f5a151d Compare September 16, 2024 21:36
@radical radical removed the blocked label Sep 16, 2024
@radical radical marked this pull request as ready for review September 16, 2024 23:17
Comment on lines 335 to 338
var consumerMessageLoggedTask =
app.WaitForTextAsync(log => log.Contains(consumerMessage), resourceName: "consumer")
.WaitAsync(TimeSpan.FromMinutes(2))
.ConfigureAwait(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this declared up here? Why not just inline it in the await inside the try catch below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to avoid missing this message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it read through the whole log from the start? If it already happened, I think it would still get seen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, it does play the whole log from the start! Maybe it should be renamed to like FindOrWaitForTextAsync.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "Waiting for this text to happen", if it has already happened, you are done waiting.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last comment is pretty minor. Mostly a question for my understanding.

This change LGTM.

@radical radical enabled auto-merge (squash) September 17, 2024 23:54
@davidfowl
Copy link
Member

@radical I think the test is passing but there are some exceptions in the logs that look by design (retries?)

@davidfowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit 5c532c7 into dotnet:main Sep 18, 2024
@radical radical deleted the eventhub-playground-test branch September 18, 2024 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants