-
Notifications
You must be signed in to change notification settings - Fork 733
Adds improved default auth to Milvus #5235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updates Milvus hosting to leverage dynamically generated default password if none provided (similar to other resources) and resulting cascading changes + tests. - Updates tags for contianer image that support setting auth
|
@eerhardt had to redo the PR (my branch was way stale). Addressed your prior feedback. Review: this does change resource and enables a null param were there wasn't before. Not sure if we've made a similiar change there -- seeking feedback on desired correct way here. |
I believe you did it correctly. 👍 |
tests/testproject/TestProject.AppHost/TestProject.AppHost.csproj
Outdated
Show resolved
Hide resolved
|
Would this allow adding Milvus playground app to the tests like in #5244 ? When I had tried it earlier on |
Yes, it should.
I thought we generated random parameter values: aspire/tests/Aspire.Playground.Tests/Infrastructure/DistributedApplicationExtensions.cs Lines 25 to 34 in 89f5fb6
Isn't that code supposed to fix this error? |
- Removed tests from testproject (handled in func) - changed tests to enable the random parameter usage
|
Any other feedback @eerhardt? |
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Nice work! Much easier to get started with Milvus.
Description
Milvus added the ability to set the root password. This change adapts to that and follows similar pattern to other config-based auth (e.g., MySql is a good analog). This requires the support of a minimum new Milvus version (2.4.7).
Fixes #4966
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow