Aspire CLI global tool target net8 #12454
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12454Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12454" |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the Aspire CLI global tool to target .NET 8.0 instead of .NET 10.0, ensuring users don't need the .NET 10 SDK to install and use the tool via dotnet tool install. The change adds conditional compilation to handle API differences between .NET versions.
Key Changes
- Reverted the global tool target framework from net10.0 to net8.0 (DefaultTargetFramework)
- Added conditional compilation for X509Certificate loading to support both .NET 8.0 and .NET 9.0+
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Cli/Aspire.Cli.csproj | Explicitly sets TargetFramework to DefaultTargetFramework for the global tool build configuration |
| src/Aspire.Cli/Backchannel/ExtensionBackchannel.cs | Adds conditional compilation to use appropriate X509Certificate loading API based on target framework |
|
@baronfel where did we land on being able to package a native AoT version of a tool alongside a regular FDD version in the same package? |
|
nothing productized for .NET 10, but you could take + test this commit to get something working for Aspire specifically. |
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. Assuming we don't need to condition the targetframework above and this works as expected
5 participants
Description
The Aspire CLI "global .net tool" now targets net10 with #10167. This means anyone using the
dotnet tool installversion will need the .NET 10 SDK to use it.Revert back to targeting
net8.0for the global tool.@DamianEdwards @davidfowl @maddymontaquila - I assume we don't want to require users to have the .NET 10 SDK to use Aspire. Is that a correct assumption?