Update KubernetesClient to v18.0.5 and fix breaking changes (#12071)

* Initial plan

* Initial exploration and plan for KubernetesClient update

Co-authored-by: mitchdenny <[email protected]>

* Update KubernetesClient to v18.0.5 and fix breaking changes

Co-authored-by: mitchdenny <[email protected]>

* Add explicit KubernetesClient reference to test projects

Co-authored-by: mitchdenny <[email protected]>

* Remove NuGet.config changes - package now in internal feed

Co-authored-by: mitchdenny <[email protected]>

* Remove explicit KubernetesClient references from test projects

Co-authored-by: mitchdenny <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: mitchdenny <[email protected]>

Author: Copilot

Directory.Packages.props

@@ -89,7 +89,7 @@
     <PackageVersion Include="Grpc.Net.ClientFactory" Version="2.71.0" />
     <PackageVersion Include="Grpc.Tools" Version="2.72.0" />
     <PackageVersion Include="Humanizer.Core" Version="2.14.1" />
-    <PackageVersion Include="KubernetesClient" Version="17.0.14" />
+    <PackageVersion Include="KubernetesClient" Version="18.0.5" />
     <PackageVersion Include="JsonPatch.Net" Version="3.3.0" />
     <PackageVersion Include="Markdig" Version="0.42.0" />
     <PackageVersion Include="Microsoft.AI.Foundry.Local" Version="0.2.0" />

src/Aspire.Hosting/Dcp/KubernetesService.cs

@@ -284,7 +284,12 @@ public Task<T> DeleteAsync<T>(string name, string? namespaceParameter = null, Ca
                             watch: true,
                             cancellationToken: restartCancellationToken);
 
-                    return responseTask.WatchAsync<T, object>(null, restartCancellationToken);
+                    // TODO: KubernetesClient v18 marked WatchAsync extension method as obsolete.
+                    // The new pattern uses Watcher<T> directly, but requires significant refactoring.
+                    // This API still works in v18.x and will be updated in a future change.
+#pragma warning disable CS0618 // Type or member is obsolete
+                    return responseTask.WatchAsync<T, object>(onError: null, restartCancellationToken);
+#pragma warning restore CS0618 // Type or member is obsolete
                 },
                 RetryOnConnectivityAndConflictErrors,
                 restartCancellationToken);

src/Aspire.Hosting/Dcp/Model/Container.cs

@@ -434,7 +434,7 @@ internal static class ContainerFileSystemEntryType
     public const string OpenSSL = "openssl";
 }
 
-internal sealed class ContainerStatus : V1Status
+internal sealed record ContainerStatus : V1Status
 {
     // Container name displayed in Docker
     [JsonPropertyName("containerName")]

src/Aspire.Hosting/Dcp/Model/ContainerExec.cs

@@ -47,7 +47,7 @@ internal sealed class ContainerExecSpec
     public List<string>? Args { get; set; }
 }
 
-internal sealed class ContainerExecStatus : V1Status
+internal sealed record ContainerExecStatus : V1Status
 {
     /// <summary>
     /// The current state of the container execution. See <see cref="ExecutableState"/> for possible values.

src/Aspire.Hosting/Dcp/Model/ContainerVolume.cs

@@ -40,7 +40,7 @@ internal static class ContainerVolumeState
     public const string Ready = "Ready";
 }
 
-internal sealed class ContainerVolumeStatus : V1Status
+internal sealed record ContainerVolumeStatus : V1Status
 {
     /// <summary>
     /// The current state of the container volume. See <see cref="ContainerVolumeState"/> for possible values.

src/Aspire.Hosting/Dcp/Model/Endpoint.cs

@@ -25,7 +25,7 @@ internal sealed class EndpointSpec
     public int? Port { get; set; }
 }
 
-internal sealed class EndpointStatus : V1Status
+internal sealed record EndpointStatus : V1Status
 {
     // Currently Endpoint has no status properties, but that may change in future.
 }

src/Aspire.Hosting/Dcp/Model/Executable.cs

@@ -101,7 +101,7 @@ internal static class ExecutionType
     public const string IDE = "IDE";
 }
 
-internal sealed class ExecutableStatus : V1Status
+internal sealed record ExecutableStatus : V1Status
 {
     /// <summary>
     /// The execution ID is the identifier for the actual-state counterpart of the Executable.

src/Aspire.Hosting/Dcp/Model/ExecutableReplicaSet.cs

@@ -58,7 +58,7 @@ internal sealed class ExecutableReplicaSetSpec
     public ExecutableTemplate Template { get; set; } = new ExecutableTemplate();
 }
 
-internal sealed class ExecutableReplicaSetStatus : V1Status
+internal sealed record ExecutableReplicaSetStatus : V1Status
 {
     // Total number of observed child executables
     [JsonPropertyName("observedReplicas")]

src/Aspire.Hosting/Dcp/Model/Network.cs

@@ -21,7 +21,7 @@ internal sealed class ContainerNetworkSpec
     public bool? Persistent { get; set; }
 }
 
-internal sealed class ContainerNetworkStatus : V1Status
+internal sealed record ContainerNetworkStatus : V1Status
 {
     // The current state of the network
     [JsonPropertyName("state")]

src/Aspire.Hosting/Dcp/Model/Service.cs

@@ -25,7 +25,7 @@ internal sealed class ServiceSpec
     public string AddressAllocationMode { get; set; } = AddressAllocationModes.Localhost;
 }
 
-internal sealed class ServiceStatus : V1Status
+internal sealed record ServiceStatus : V1Status
 {
     // The actual address the service is running on
     [JsonPropertyName("effectiveAddress")]