Add feature flag for SDK installation (dotnetSdkInstallationEnabled)

- Add KnownFeatures.DotNetSdkInstallationEnabled constant
- Update SdkInstallHelper to check feature flag before offering installation
- Default feature flag to true (enabled by default)
- Add IFeatures parameter to EnsureSdkInstalledAsync method
- Store _features field in AddCommand and ExecCommand
- Update all command calls to pass _features parameter

Addresses feedback from @mitchdenny to add feature flag control.

Co-authored-by: mitchdenny <[email protected]>

Author: Copilot

src/Aspire.Cli/Commands/AddCommand.cs

@@ -25,6 +25,7 @@ internal sealed class AddCommand : BaseCommand
     private readonly AspireCliTelemetry _telemetry;
     private readonly IDotNetSdkInstaller _sdkInstaller;
     private readonly ICliHostEnvironment _hostEnvironment;
+    private readonly IFeatures _features;
 
     public AddCommand(IDotNetCliRunner runner, IPackagingService packagingService, IInteractionService interactionService, IProjectLocator projectLocator, IAddCommandPrompter prompter, AspireCliTelemetry telemetry, IDotNetSdkInstaller sdkInstaller, IFeatures features, ICliUpdateNotifier updateNotifier, CliExecutionContext executionContext, ICliHostEnvironment hostEnvironment)
         : base("add", AddCommandStrings.Description, features, updateNotifier, executionContext, interactionService)
@@ -37,6 +38,7 @@ public AddCommand(IDotNetCliRunner runner, IPackagingService packagingService, I
         ArgumentNullException.ThrowIfNull(telemetry);
         ArgumentNullException.ThrowIfNull(sdkInstaller);
         ArgumentNullException.ThrowIfNull(hostEnvironment);
+        ArgumentNullException.ThrowIfNull(features);
 
         _runner = runner;
         _packagingService = packagingService;
@@ -45,6 +47,7 @@ public AddCommand(IDotNetCliRunner runner, IPackagingService packagingService, I
         _telemetry = telemetry;
         _sdkInstaller = sdkInstaller;
         _hostEnvironment = hostEnvironment;
+        _features = features;
 
         var integrationArgument = new Argument<string>("integration");
         integrationArgument.Description = AddCommandStrings.IntegrationArgumentDescription;
@@ -67,7 +70,7 @@ public AddCommand(IDotNetCliRunner runner, IPackagingService packagingService, I
     protected override async Task<int> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             return ExitCodeConstants.SdkNotInstalled;
         }

src/Aspire.Cli/Commands/ExecCommand.cs

@@ -26,6 +26,7 @@ internal class ExecCommand : BaseCommand
     private readonly AspireCliTelemetry _telemetry;
     private readonly IDotNetSdkInstaller _sdkInstaller;
     private readonly ICliHostEnvironment _hostEnvironment;
+    private readonly IFeatures _features;
 
     public ExecCommand(
         IDotNetCliRunner runner,
@@ -48,6 +49,7 @@ public ExecCommand(
         ArgumentNullException.ThrowIfNull(telemetry);
         ArgumentNullException.ThrowIfNull(sdkInstaller);
         ArgumentNullException.ThrowIfNull(hostEnvironment);
+        ArgumentNullException.ThrowIfNull(features);
 
         _runner = runner;
         _certificateService = certificateService;
@@ -56,6 +58,7 @@ public ExecCommand(
         _telemetry = telemetry;
         _sdkInstaller = sdkInstaller;
         _hostEnvironment = hostEnvironment;
+        _features = features;
 
         var projectOption = new Option<FileInfo?>("--project");
         projectOption.Description = ExecCommandStrings.ProjectArgumentDescription;
@@ -84,7 +87,7 @@ public ExecCommand(
     protected override async Task<int> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             return ExitCodeConstants.SdkNotInstalled;
         }

src/Aspire.Cli/Commands/InitCommand.cs

@@ -97,7 +97,7 @@ public InitCommand(
     protected override async Task<int> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             return ExitCodeConstants.SdkNotInstalled;
         }

src/Aspire.Cli/Commands/NewCommand.cs

@@ -124,7 +124,7 @@ private async Task<ITemplate> GetProjectTemplateAsync(ParseResult parseResult, C
     protected override async Task<int> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             return ExitCodeConstants.SdkNotInstalled;
         }

src/Aspire.Cli/Commands/PublishCommandBase.cs

@@ -88,7 +88,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
         StartTerminalProgressBar();
 
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             // Send terminal progress bar stop sequence
             StopTerminalProgressBar();

src/Aspire.Cli/Commands/RunCommand.cs

@@ -103,7 +103,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
         }
 
         // Check if the .NET SDK is available
-        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _hostEnvironment, cancellationToken))
+        if (!await SdkInstallHelper.EnsureSdkInstalledAsync(_sdkInstaller, InteractionService, _features, _hostEnvironment, cancellationToken))
         {
             return ExitCodeConstants.SdkNotInstalled;
         }

src/Aspire.Cli/KnownFeatures.cs

@@ -17,4 +17,5 @@ internal static class KnownFeatures
     public static string StagingChannelEnabled => "stagingChannelEnabled";
     public static string DefaultWatchEnabled => "defaultWatchEnabled";
     public static string ShowAllTemplates => "showAllTemplates";
+    public static string DotNetSdkInstallationEnabled => "dotnetSdkInstallationEnabled";
 }

src/Aspire.Cli/Utils/SdkInstallHelper.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Globalization;
+using Aspire.Cli.Configuration;
 using Aspire.Cli.DotNet;
 using Aspire.Cli.Interaction;
 using Aspire.Cli.Resources;
@@ -15,21 +16,24 @@ internal static class SdkInstallHelper
 {
     /// <summary>
     /// Ensures that the .NET SDK is installed and available, displaying an error message if it's not.
-    /// If the SDK is missing, prompts the user to install it automatically (if in interactive mode).
+    /// If the SDK is missing, prompts the user to install it automatically (if in interactive mode and feature is enabled).
     /// </summary>
     /// <param name="sdkInstaller">The SDK installer service.</param>
     /// <param name="interactionService">The interaction service for user communication.</param>
+    /// <param name="features">The features service for checking if SDK installation is enabled.</param>
     /// <param name="hostEnvironment">The CLI host environment for detecting interactive capabilities.</param>
     /// <param name="cancellationToken">Cancellation token.</param>
     /// <returns>True if the SDK is available, false if it's missing.</returns>
     public static async Task<bool> EnsureSdkInstalledAsync(
         IDotNetSdkInstaller sdkInstaller,
         IInteractionService interactionService,
+        IFeatures features,
         ICliHostEnvironment? hostEnvironment = null,
         CancellationToken cancellationToken = default)
     {
         ArgumentNullException.ThrowIfNull(sdkInstaller);
         ArgumentNullException.ThrowIfNull(interactionService);
+        ArgumentNullException.ThrowIfNull(features);
 
         var (success, highestVersion, minimumRequiredVersion) = await sdkInstaller.CheckAsync(cancellationToken);
 
@@ -43,8 +47,11 @@ public static async Task<bool> EnsureSdkInstalledAsync(
                 detectedVersion);
             interactionService.DisplayError(sdkErrorMessage);
 
-            // Only offer to install if we support interactive input
-            if (hostEnvironment?.SupportsInteractiveInput == true)
+            // Only offer to install if:
+            // 1. The feature is enabled (default: true)
+            // 2. We support interactive input
+            if (features.IsFeatureEnabled(KnownFeatures.DotNetSdkInstallationEnabled, defaultValue: true) &&
+                hostEnvironment?.SupportsInteractiveInput == true)
             {
                 // Offer to install the SDK automatically
                 var shouldInstall = await interactionService.ConfirmAsync(