Skip to content

Commit dfea975

Browse files
committed
[bundle] Include cross*.d* in the bundle
Commit a08cd80 updated `mono-runtimes.targets` to copy e.g. `cross-arm64.exe` to `cross-arm64.d.exe`, then to *strip* `cross-arm64.exe` in an effort to (eventually) reduce `.vsix` size. While admirable, there was one oversight: the original un-`strip`ped `cross-arm64.d.exe` *wasn't* added to the bundle, meaning the copy with debug symbols is *lost*. Oops. Correct this oversight and add `cross-*.d*` to the bundle.
1 parent e6a51ae commit dfea975

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

build-tools/bundle/bundle-path.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<Target Name="GetBundleFileName"
2525
DependsOnTargets="_GetHashes">
2626
<PropertyGroup>
27-
<XABundleFileName>bundle-v15-$(Configuration)-$(HostOS)-libzip=$(_LibZipHash),llvm=$(_LlvmHash),mono=$(_MonoHash).zip</XABundleFileName>
27+
<XABundleFileName>bundle-v16-$(Configuration)-$(HostOS)-libzip=$(_LibZipHash),llvm=$(_LlvmHash),mono=$(_MonoHash).zip</XABundleFileName>
2828
</PropertyGroup>
2929
</Target>
3030
</Project>

build-tools/mono-runtimes/mono-runtimes.targets

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,9 @@
579579
<BundleItem Include="@(_RuntimeEglibHeaderOutput)" />
580580
<BundleItem Include="@(_MonoConstsOutput)" />
581581
<BundleItem Include="@(_LlvmTargetBinary)" />
582+
<BundleItem Include="$(OutputPath)\%(_MonoCrossRuntime.InstallPath)%(_MonoCrossRuntime.CrossMonoName).d%(_MonoCrossRuntime.ExeSuffix)"
583+
Condition=" '@(_MonoCrossRuntime)' != '' "
584+
/>
582585
<BundleItem Include="$(OutputPath)\%(_MonoCrossRuntime.InstallPath)%(_MonoCrossRuntime.CrossMonoName)%(_MonoCrossRuntime.ExeSuffix)"
583586
Condition=" '@(_MonoCrossRuntime)' != '' "
584587
/>

0 commit comments

Comments
 (0)