- Fixed timestamp truncation from long to uint causing cached tokens to be erroneously expired.

Author: paulmedynski

src/Microsoft.Data.SqlClient.Extensions/Abstractions/doc/SqlAuthenticationProviderException.xml

@@ -67,5 +67,11 @@
         ShouldRetry is false.
       </summary>
     </RetryPeriod>
+    <ToString>
+      <returns>
+        A string that includes the base exception information along with all
+        property values.
+      </returns>
+    </ToString>
   </members>
 </docs>

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs

@@ -47,5 +47,13 @@ protected SqlAuthenticationProviderException(
     /// <include file='../doc/SqlAuthenticationProviderException.xml' path='docs/members[@name="SqlAuthenticationProviderException"]/RetryPeriod/*'/>
     public int RetryPeriod { get; }
 
+    /// <include file='../doc/SqlAuthenticationProviderException.xml' path='docs/members[@name="SqlAuthenticationProviderException"]/ToString/*'/>
+    public override string ToString()
+    {
+        return base.ToString() +
+            $" Method={Method} FailureCode={FailureCode}" +
+            $" ShouldRetry={ShouldRetry} RetryPeriod={RetryPeriod}";
+    }
+
     private const string Unknown = "Unknown";
 }

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

@@ -131,7 +131,8 @@ internal sealed class SqlInternalConnectionTds : SqlInternalConnection, IDisposa
         internal bool _federatedAuthenticationInfoReceived;
 
         // The Federated Authentication returned by TryGetFedAuthTokenLocked or GetFedAuthToken.
-        SqlFedAuthToken _fedAuthToken = null;
+        private SqlFedAuthToken _fedAuthToken = null;
+
         internal byte[] _accessTokenInBytes;
         internal readonly Func<SqlAuthenticationParameters, CancellationToken, Task<SqlAuthenticationToken>> _accessTokenCallback;
         internal readonly SspiContextProvider _sspiContextProvider;
@@ -2417,7 +2418,7 @@ internal void OnFedAuthInfo(SqlFedAuthInfo fedAuthInfo)
                 // generating a new access token on this thread.
                 _fedAuthToken = new(
                     dbConnectionPoolAuthenticationContext.AccessToken,
-                    (uint)dbConnectionPoolAuthenticationContext.ExpirationTime.ToFileTime());
+                    dbConnectionPoolAuthenticationContext.ExpirationTime.ToFileTime());
             }
 
             Debug.Assert(_fedAuthToken != null && _fedAuthToken.AccessToken != null, "_fedAuthToken and _fedAuthToken.AccessToken cannot be null.");

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

@@ -2473,7 +2473,7 @@ internal void OnFedAuthInfo(SqlFedAuthInfo fedAuthInfo)
                 // generating a new access token on this thread.
                 _fedAuthToken = new(
                     dbConnectionPoolAuthenticationContext.AccessToken,
-                    (uint)dbConnectionPoolAuthenticationContext.ExpirationTime.ToFileTime());
+                    dbConnectionPoolAuthenticationContext.ExpirationTime.ToFileTime());
             }
 
             Debug.Assert(_fedAuthToken != null && _fedAuthToken.AccessToken != null, "_fedAuthToken and _fedAuthToken.AccessToken cannot be null.");

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs

@@ -1451,17 +1451,6 @@ internal static Exception UnsupportedFeatureAndToken(SqlInternalConnectionTds in
             return exc;
         }
 
-        internal static Exception Azure_ManagedIdentityException(string msg)
-        {
-            SqlErrorCollection errors = new SqlErrorCollection
-            {
-                new SqlError(0, (byte)0x00, TdsEnums.FATAL_ERROR_CLASS, null, msg, "", 0)
-            };
-            SqlException exc = SqlException.CreateException(errors, null);
-            exc._doNotReconnect = true; // disable open retry logic on this error
-            return exc;
-        }
-
         #region Always Encrypted Errors
 
         #region Always Encrypted - Certificate Store Provider Errors

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs

@@ -156,7 +156,7 @@ internal sealed class SqlFedAuthToken
 
         internal SqlFedAuthToken(
             byte[] accessToken,
-            uint expirationFileTime)
+            long expirationFileTime)
         {
             AccessToken = accessToken;
             DataLen = (uint)AccessToken.Length;