Skip to content

Conversation

@chrislearn
Copy link
Contributor

No description provided.

@chrislearn chrislearn marked this pull request as draft July 17, 2025 02:25
@haixuanTao
Copy link
Collaborator

FYI, updating rust edition makes it hard to use dora node api with older rust version. I would maybe wait to upgrade rust edition unless it is strictly necessary

@phil-opp
Copy link
Collaborator

I think the Rust 2024 edition was introduced in Rust 1.85, which is the lowest Rust version we support. So it should be ok.

@chrislearn chrislearn marked this pull request as ready for review July 30, 2025 09:50
@phil-opp
Copy link
Collaborator

I force-pushed the branch to remove commits 8867ea2 and 64af27b from this PR. These are commits of another PR that are part of main already, no need to re-apply them.

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'll try to clean up the git history before merging.

@phil-opp phil-opp enabled auto-merge July 30, 2025 11:33
@phil-opp phil-opp merged commit b7bfe30 into dora-rs:main Jul 30, 2025
176 checks passed
@chrislearn
Copy link
Contributor Author

Maybe we can consider using Squash and merge when merging PRs in the future, this will make the history of main branch much cleaner.
image

@phil-opp
Copy link
Collaborator

Depends on the PR. For example, I prefer multiple commits for larger PRs that can be split into multiple separate steps. This way, the commits on the main branch are smaller and git blame output becomes more useful.

For this PR, keeping the the formatting and clippy changes in separate commits makes the history and diffs easier to read in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants