Replace deprecated String.prototype.substr() (mrdoob#23525)

String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <[email protected]>

Author: CommanderRoot

docs/index.html

@@ -327,9 +327,9 @@ <h1><a href="https://threejs.org">three.js</a></h1>
 
 			const hash = location.hash;
 			if ( hash === '' ) return;
-			const docType = hash.substr( 0, hash.indexOf( '/' ) + 1 );
-			let docLink = hash.substr( hash.indexOf( '/' ) + 1 );
-			docLink = docLink.substr( docLink.indexOf( '/' ) );
+			const docType = hash.slice( 0, hash.indexOf( '/' ) + 1 );
+			let docLink = hash.slice( hash.indexOf( '/' ) + 1 );
+			docLink = docLink.slice( docLink.indexOf( '/' ) );
 			location.href = docType + language + docLink;
 
 		}
@@ -342,7 +342,7 @@ <h1><a href="https://threejs.org">three.js</a></h1>
 
 			if ( search.indexOf( '?q=' ) !== - 1 ) {
 
-				return decodeURI( search.substr( 3 ) );
+				return decodeURI( search.slice( 3 ) );
 
 			}
 

docs/page.js

@@ -6,7 +6,7 @@ if ( ! window.frameElement && window.location.protocol !== 'file:' ) {
 
 	let href = window.location.href;
 	const splitIndex = href.lastIndexOf( '/docs/' ) + 6;
-	const docsBaseURL = href.substr( 0, splitIndex );
+	const docsBaseURL = href.slice( 0, splitIndex );
 
 	let hash = window.location.hash;
 
@@ -36,22 +36,22 @@ function onDocumentLoad() {
 	switch ( section ) {
 
 		case 'api':
-			localizedPath = /\/api\/[A-Za-z0-9\/]+/.exec( pathname ).toString().substr( 5 );
+			localizedPath = /\/api\/[A-Za-z0-9\/]+/.exec( pathname ).toString().slice( 5 );
 
 			// Remove localized part of the path (e.g. 'en/' or 'es-MX/'):
 			path = localizedPath.replace( /^[A-Za-z0-9-]+\//, '' );
 
 			break;
 
 		case 'examples':
-			path = localizedPath = /\/examples\/[A-Za-z0-9\/]+/.exec( pathname ).toString().substr( 10 );
+			path = localizedPath = /\/examples\/[A-Za-z0-9\/]+/.exec( pathname ).toString().slice( 10 );
 			break;
 
 		case 'manual':
 			name = name.replace( /\-/g, ' ' );
 
 			path = pathname.replace( /\ /g, '-' );
-			path = localizedPath = /\/manual\/[-A-Za-z0-9\/]+/.exec( path ).toString().substr( 8 );
+			path = localizedPath = /\/manual\/[-A-Za-z0-9\/]+/.exec( path ).toString().slice( 8 );
 			break;
 
 	}

editor/index.html

@@ -223,9 +223,9 @@
 			var isLoadingFromHash = false;
 			var hash = window.location.hash;
 
-			if ( hash.substr( 1, 5 ) === 'file=' ) {
+			if ( hash.slice( 1, 6 ) === 'file=' ) {
 
-				var file = hash.substr( 6 );
+				var file = hash.slice( 6 );
 
 				if ( confirm( 'Any unsaved data will be lost. Are you sure?' ) ) {
 

editor/js/LoaderUtils.js

@@ -60,7 +60,7 @@ const LoaderUtils = {
 
 					files.push( file );
 
-					filesMap[ entry.fullPath.substr( 1 ) ] = file;
+					filesMap[ entry.fullPath.slice( 1 ) ] = file;
 					onEntryHandled();
 
 				} );

examples/index.html

@@ -381,7 +381,7 @@ <h1><a href="https://threejs.org">three.js</a></h1>
 
 			if ( search.indexOf( '?q=' ) !== - 1 ) {
 
-				return decodeURI( search.substr( 3 ) );
+				return decodeURI( search.slice( 3 ) );
 
 			}
 

examples/js/exporters/GLTFExporter.js

@@ -1352,7 +1352,7 @@
 			for ( let attributeName in geometry.attributes ) {
 
 				// Ignore morph target attributes, which are exported later.
-				if ( attributeName.substr( 0, 5 ) === 'morph' ) continue;
+				if ( attributeName.slice( 0, 5 ) === 'morph' ) continue;
 				const attribute = geometry.attributes[ attributeName ];
 				attributeName = nameConversion[ attributeName ] || attributeName.toUpperCase(); // Prefix all geometry attributes except the ones specifically
 				// listed in the spec; non-spec attributes are considered custom.

examples/js/loaders/ColladaLoader.js

@@ -2805,7 +2805,7 @@
 							const param = child.getElementsByTagName( 'param' )[ 0 ];
 							data.axis = param.textContent;
 							const tmpJointIndex = data.axis.split( 'inst_' ).pop().split( 'axis' )[ 0 ];
-							data.jointIndex = tmpJointIndex.substr( 0, tmpJointIndex.length - 1 );
+							data.jointIndex = tmpJointIndex.substring( 0, tmpJointIndex.length - 1 );
 							break;
 
 					}

examples/js/loaders/KMZLoader.js

@@ -48,7 +48,7 @@
 
 				for ( const path in zip ) {
 
-					if ( path.substr( - url.length ) === url ) {
+					if ( path.slice( - url.length ) === url ) {
 
 						return zip[ path ];
 

examples/js/loaders/LWOLoader.js

@@ -955,7 +955,7 @@
 
 		const index = url.indexOf( dir );
 		if ( index === - 1 ) return './';
-		return url.substr( 0, index );
+		return url.slice( 0, index );
 
 	}
 

examples/js/loaders/OBJLoader.js

@@ -491,7 +491,7 @@
 
 				} else if ( lineFirstChar === 'f' ) {
 
-					const lineData = line.substr( 1 ).trim();
+					const lineData = line.slice( 1 ).trim();
 					const vertexData = lineData.split( /\s+/ );
 					const faceVertices = []; // Parse the face vertex data into an easy to work with format
 
@@ -545,7 +545,7 @@
 
 				} else if ( lineFirstChar === 'p' ) {
 
-					const lineData = line.substr( 1 ).trim();
+					const lineData = line.slice( 1 ).trim();
 					const pointData = lineData.split( ' ' );
 					state.addPointGeometry( pointData );
 
@@ -555,8 +555,8 @@
 					// or
 					// g group_name
 					// WORKAROUND: https://bugs.chromium.org/p/v8/issues/detail?id=2869
-					// let name = result[ 0 ].substr( 1 ).trim();
-					const name = ( ' ' + result[ 0 ].substr( 1 ).trim() ).substr( 1 );
+					// let name = result[ 0 ].slice( 1 ).trim();
+					const name = ( ' ' + result[ 0 ].slice( 1 ).trim() ).slice( 1 );
 					state.startObject( name );
 
 				} else if ( _material_use_pattern.test( line ) ) {