Add an init container to ensure ambient mode networking is up. (#344)

Author: ddl-r-abdulaziz

deployments/helm/hephaestus/templates/controller/deployment.yaml

@@ -43,6 +43,33 @@ spec:
       serviceAccountName: {{ include "hephaestus.serviceAccountName" . }}
       securityContext:
         {{- toYaml .Values.controller.podSecurityContext | nindent 8 }}
+      {{- if .Values.waitForNetworking }}
+      initContainers:
+        - name: wait-for-networking
+          securityContext:
+            {{- toYaml .Values.controller.manager.containerSecurityContext | nindent 12 }}
+          image: {{ .Values.curl_image }}
+          imagePullPolicy: {{ .Values.controller.manager.image.pullPolicy }}
+          command: [ 'sh', '-c' ]
+          args:
+            - |
+              # Init containers seem to fix https://dominodatalab.atlassian.net/browse/DOM-70981
+              # We're not sure why, but this init container is here as a temporary solution.
+              echo "1 second sleep..."
+              sleep 1
+              echo "...done"
+          {{- with .Values.controller.manager }}
+          {{- if or .extraEnvVars $.Values.podEnv }}
+          env:
+            {{- with .extraEnvVars }}
+            {{- include "common.tplvalues.render" (dict "value" . "context" $) | nindent 12 }}
+            {{- end }}
+            {{- with $.Values.podEnv }}
+              {{- toYaml . | nindent 12 }}
+            {{- end }}
+          {{- end }}
+          {{- end }}
+      {{- end }}
       containers:
         - name: manager
           securityContext:

deployments/helm/hephaestus/values.yaml

@@ -405,3 +405,9 @@ buildkit:
                   values:
                     - {{ .Chart.Name }}
             topologyKey: "kubernetes.io/hostname"
+
+# waitForNetworking starts an initContainer that requires a curl_image
+# Set this to true in istio ambient mode to cause Hephaestus Manager to start up
+# with networking. We're not sure why this works. See: https://dominodatalab.atlassian.net/browse/DOM-70981
+waitForNetworking: false
+curl_image: curlimages/curl:latest