Embrace nullptr over NULL and 0 #11760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
approved these changes
Apr 15, 2023
Member
BhaaLseN
left a comment
BhaaLseN
left a comment
There was a problem hiding this comment.
LGTM (untested).
One style remark, but this could potentially be punted to a later point that forces consistency across everything (rather than consistency inside the file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the functional changes to Dolphin's source code from PR #11709, as that PR is held up by requiring CMake 3.25 support on all platforms. Preferring nullptr over zero as a null pointer constant is a coding guideline for the Dolphin Emulator project, as well as a C++ Core Guideline, though I'm sure I don't have to tell you this.