-
Notifications
You must be signed in to change notification settings - Fork 0
Update typescript SDK #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| assignments: null, | ||
| createdDate: new Date("2023-05-03T09:49:49.817Z"), | ||
| updatedDate: new Date("2025-01-27T12:20:15.711Z"), | ||
| createdDate: new Date("2025-01-27T12:20:15.711Z"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why created date is getting updated? and also should not be updated date is the current date ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples are part of provided swagger files by api team. They might have just updates the examples during testing
| import { UpdateWorkspaceResponse } from "@docusign/iam-sdk/models/components"; | ||
|
|
||
| let value: UpdateWorkspaceResponse = { | ||
| workspaceId: "23c8f1ba-6688-414c-88a8-0b687d4e849d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is sample workspaceId or actualId ? we should not provide actual workspace id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comment. These are provided in swagger itself. And it can be a simple uuid.
| updatedDate: new Date("2023-12-29T22:45:15.002Z"), | ||
| canView: true, | ||
| createdDate: null, | ||
| updatedDate: new Date("2023-03-04T08:54:31.312Z"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why updated date is not the current date ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as this #9 (comment)
| import { GetWorkspaceBrandRequest } from "@docusign/iam-sdk/models/operations"; | ||
|
|
||
| let value: GetWorkspaceBrandRequest = { | ||
| accountId: "4dcaad66-361d-4ae0-b2a1-54d474711d0a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure its sample id not the actual id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added here #9 (comment)
| import { UpdateWorkspaceBrandRequest } from "@docusign/iam-sdk/models/operations"; | ||
|
|
||
| let value: UpdateWorkspaceBrandRequest = { | ||
| accountId: "760a8a87-506f-4362-86b3-a3ab769be657", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9 (comment) have addd here
| import { UpdateWorkspaceRequest } from "@docusign/iam-sdk/models/operations"; | ||
|
|
||
| let value: UpdateWorkspaceRequest = { | ||
| accountId: "a6134c26-d088-4d31-b23f-5eef1d21ac9f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
| description: "mid tired creamy bourgeoisie hmph dead", | ||
| status: "complete", | ||
| dueDate: "<value>", | ||
| dueDate: new Date("2025-03-30T10:11:35.281Z"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due date should be current date ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9 (comment)
Have added here
|
|
||
| async function run() { | ||
| const result = await iamClient.workspaces.workspaceBrands.updateWorkspaceBrand({ | ||
| accountId: "1b06d538-9938-4fc1-ac20-f9284b7b9a0a", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please verify if these ids are actual id or sample id ? we publish only sample id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added here #9 (comment)
Typescript SDK Changes Detected:
iamclient.workspaces.workspaceUploadRequest.createWorkspaceUploadRequest():responseChanged Breakingiamclient.workspaces.workspaceUploadRequest.getWorkspaceUploadRequests():response.data.[]Changed Breakingiamclient.workspaces.workspaceUploadRequest.getWorkspaceUploadRequest():responseChanged Breakingiamclient.workspaces.workspaceUploadRequest.updateWorkspaceUploadRequest():request.updateWorkspaceUploadRequestBody.dueDateChanged BreakingresponseChanged Breakingiamclient.workspaces.workspaceBrands.getWorkspaceBrand(): Addediamclient.workspaces.workspaceBrands.updateWorkspaceBrand(): Addediamclient.workspaces.workspaces.updateWorkspace(): AddedOpenAPI Change Summary
TYPESCRIPT CHANGELOG
🐝 New Features
🐛 Bug Fixes