From 8db4e1614e7db75c2ae74e75bf1285be8fbcf383 Mon Sep 17 00:00:00 2001 From: Igor Khomenko Date: Thu, 28 Jun 2018 22:43:18 +0300 Subject: [PATCH 1/2] Ability to set a custom page title via _sidebar.md --- src/core/event/sidebar.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/event/sidebar.js b/src/core/event/sidebar.js index 103e72436..577766e5e 100644 --- a/src/core/event/sidebar.js +++ b/src/core/event/sidebar.js @@ -78,7 +78,11 @@ export function getAndActive(router, el, isParent, autoTitle) { }) if (autoTitle) { - dom.$.title = target ? `${target.innerText} - ${title}` : title + if(target && target.title){ + dom.$.title = target.title + }else{ + dom.$.title = target ? `${target.innerText} - ${title}` : title + } } return target From ffa9374ad2cbb47d8330f95fee3db835d4c87c0f Mon Sep 17 00:00:00 2001 From: Igor Khomenko Date: Fri, 29 Jun 2018 19:32:49 +0300 Subject: [PATCH 2/2] fixes after review --- src/core/event/sidebar.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/core/event/sidebar.js b/src/core/event/sidebar.js index 577766e5e..b16cd70e2 100644 --- a/src/core/event/sidebar.js +++ b/src/core/event/sidebar.js @@ -78,11 +78,7 @@ export function getAndActive(router, el, isParent, autoTitle) { }) if (autoTitle) { - if(target && target.title){ - dom.$.title = target.title - }else{ - dom.$.title = target ? `${target.innerText} - ${title}` : title - } + dom.$.title = target ? (target.title || `${target.innerText} - ${title}`) : title } return target