Skip to content

feat: enable rich tables#368

Merged
vagenas merged 8 commits intomainfrom
rich-tables
Aug 27, 2025
Merged

feat: enable rich tables#368
vagenas merged 8 commits intomainfrom
rich-tables

Conversation

@vagenas
Copy link
Member

@vagenas vagenas commented Aug 17, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2025

DCO Check Passed

Thanks @vagenas, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Aug 17, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@vagenas vagenas changed the title feat: first stab at rich table cells feat: enable rich tables Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/types/doc/document.py 90.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@vagenas vagenas marked this pull request as ready for review August 27, 2025 04:19
@dosubot
Copy link

dosubot bot commented Aug 27, 2025

Related Documentation
0 document(s) may need updating based on files changed in this PR

How did I do? Any feedback?  Join Discord

Signed-off-by: Panos Vagenas <[email protected]>
dolfim-ibm
dolfim-ibm previously approved these changes Aug 27, 2025
Copy link
Member

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Member

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, only minor comment: could you add the RichTableCell and AnyTableCell in https://github.com/docling-project/docling-core/blob/main/docling_core/types/doc/__init__.py?

Copy link
Member

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@vagenas vagenas merged commit 1d04154 into main Aug 27, 2025
12 checks passed
@vagenas vagenas deleted the rich-tables branch August 27, 2025 08:07
@dosubot
Copy link

dosubot bot commented Aug 27, 2025

Documentation updates
Checked 2 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@simonschoe
Copy link

@vagenas Is this already fully implemented? When trying out the ground truth documents introduced with MR and use an document.iterate_items() loop, it seems like rich tables are not yet correctly accounted for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants