only look for required image in bake metadata #12930

ndeloof · 2025-06-11T10:02:45Z

What I did

Related issue
closes #12928

(not mandatory) A picture of a cute animal, if possible in relation to what you did

glours

it seams image should be added to the tags list 😅

Signed-off-by: Nicolas De Loof <[email protected]>

ndeloof · 2025-06-11T10:23:10Z

yes, I removed the wrong line 🥸

codecov · 2025-06-11T10:35:04Z

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.42%. Comparing base (ec49bac) to head (5be1a82).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/compose/build_bake.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12930      +/-   ##
==========================================
+ Coverage   53.37%   53.42%   +0.05%     
==========================================
  Files         160      160              
  Lines       16642    16659      +17     
==========================================
+ Hits         8882     8900      +18     
  Misses       6848     6848              
+ Partials      912      911       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | minor | `v2.36.2` -> `v2.37.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.37.1`](https://github.com/docker/compose/releases/tag/v2.37.1) [Compare Source](docker/compose@v2.37.0...v2.37.1) #### What's Changed ##### ✨ Improvements - Add support for extra_hosts building with bake by [@ndeloof](https://github.com/ndeloof) in docker/compose#12935 ##### 🐛 Fixes - Fix SIGSEGV on Enable Watch by [@ndeloof](https://github.com/ndeloof) in docker/compose#12909 - Revert docker compose images JSON output to array format by [@x0rw](https://github.com/x0rw) in docker/compose#12917 - Sanitize service name so they can be used as bake targets by [@ndeloof](https://github.com/ndeloof) in docker/compose#12925 - Only look for required image in bake metadata by [@ndeloof](https://github.com/ndeloof) in docker/compose#12930 - Don't create metadatafile, just generate a random name by [@ndeloof](https://github.com/ndeloof) in docker/compose#12931 - Fix the generated manifest for compose artifacts by [@jcarter3](https://github.com/jcarter3) in docker/compose#12933 - Fix support for additional_contexts with service sub-dependencies by [@ndeloof](https://github.com/ndeloof) in docker/compose#12936 - Fix panic on failure starting plugin server by [@ndeloof](https://github.com/ndeloof) in docker/compose#12914 ##### 🔧 Internal - Do not forget to remove the bake metadata file by [@glours](https://github.com/glours) in docker/compose#12912 ##### ⚙️ Dependencies - Bump golang.org/x/sync v0.15.0 by [@ndeloof](https://github.com/ndeloof) in docker/compose#12913 - Build(deps): bump google.golang.org/grpc from 1.72.2 to 1.73.0 by [@dependabot](https://github.com/dependabot) in docker/compose#12910 #### New Contributors - [@x0rw](https://github.com/x0rw) made their first contribution in docker/compose#12917 - [@jcarter3](https://github.com/jcarter3) made their first contribution in docker/compose#12933 **Full Changelog**: docker/compose@v2.37.0...v2.37.1 ### [`v2.37.0`](https://github.com/docker/compose/releases/tag/v2.37.0) [Compare Source](docker/compose@v2.36.2...v2.37.0) #### What's Changed ℹ️ `bake` is now used as the default images builder, if you don't want to use it you could opt-out by setting the `COMPOSE_BAKE` env variable to `false` ##### ✨ Improvements - Add compose bridge by [@glours](https://github.com/glours) in docker/compose#12866 - Include platform and creation date listing image by [@ndeloof](https://github.com/ndeloof) in docker/compose#12856 - Add support of metadata subcommand for provider services by [@glours](https://github.com/glours) in docker/compose#12903 - Use bake by default by [@ndeloof](https://github.com/ndeloof) in docker/compose#12699 ##### 🐛 Fixes - (Re)start dependent services after watch rebuilt image by [@ndeloof](https://github.com/ndeloof) in docker/compose#12879 - Resolve symlinks while making dockerfile path absolute by [@ndeloof](https://github.com/ndeloof) in docker/compose#12884 - Fix support for `BUILDKIT_PROGRESS` by [@ndeloof](https://github.com/ndeloof) in docker/compose#12894 - Build dependent service images when required by [@ndeloof](https://github.com/ndeloof) in docker/compose#12896 - Fix recreate network (and connected containers) on config updates by [@ndeloof](https://github.com/ndeloof) in docker/compose#12899 - `pull` does not require `env_file` being resolved by [@ndeloof](https://github.com/ndeloof) in docker/compose#12904 ##### 🔧 Internal - Refactor: use slices.Contains to simplify code by [@tongjicoder](https://github.com/tongjicoder) in docker/compose#12877 - Remove utils.Contains to prefer slice.ContainsFunc by [@ndeloof](https://github.com/ndeloof) in docker/compose#12878 - Fix typo in suggestion log by [@Carlos-err406](https://github.com/Carlos-err406) in docker/compose#12893 - Replace uses of golang.org/x/exp/(maps|slices) for stdlib and fix linting by [@thaJeztah](https://github.com/thaJeztah) in docker/compose#12885 - Debug message to help diagnose platform mismatch by [@ndeloof](https://github.com/ndeloof) in docker/compose#12905 - (refactoting) Move watch logic into a dedicated Watcher type by [@ndeloof](https://github.com/ndeloof) in docker/compose#12865 ##### ⚙️ Dependencies - Bump cli-doc-tools to v0.10.0 by [@glours](https://github.com/glours) in docker/compose#12855 - Bump github.com/docker/docker, docker/cli v28.2.2 by [@thaJeztah](https://github.com/thaJeztah) in docker/compose#12875 - Build(deps): bump google.golang.org/grpc from 1.72.1 to 1.72.2 by [@dependabot](https://github.com/dependabot) in docker/compose#12872 #### New Contributors - [@tongjicoder](https://github.com/tongjicoder) made their first contribution in docker/compose#12877 - [@Carlos-err406](https://github.com/Carlos-err406) made their first contribution in docker/compose#12893 **Full Changelog**: docker/compose@v2.36.2...v2.37.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

ndeloof requested a review from a team as a code owner June 11, 2025 10:02

ndeloof requested a review from glours June 11, 2025 10:02

ndeloof force-pushed the bake_fix branch from 4db4dd9 to dba32a2 Compare June 11, 2025 10:03

glours approved these changes Jun 11, 2025

View reviewed changes

glours reviewed Jun 11, 2025

View reviewed changes

only look for required image in bake metadata

5be1a82

Signed-off-by: Nicolas De Loof <[email protected]>

ndeloof force-pushed the bake_fix branch from dba32a2 to 5be1a82 Compare June 11, 2025 10:22

glours merged commit 9753079 into docker:main Jun 11, 2025
28 checks passed

ndeloof deleted the bake_fix branch June 11, 2025 12:14

BrewTestBot mentioned this pull request Jun 12, 2025

docker-compose 2.37.1 Homebrew/homebrew-core#226681

Merged

rancherbot mentioned this pull request Jun 12, 2025

rddepman: bump dockerCompose from 2.37.0 to 2.37.1 rancher-sandbox/rancher-desktop#8778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

only look for required image in bake metadata #12930

only look for required image in bake metadata #12930

ndeloof commented Jun 11, 2025

Uh oh!

glours left a comment

Uh oh!

ndeloof commented Jun 11, 2025

Uh oh!

codecov bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

only look for required image in bake metadata #12930

only look for required image in bake metadata #12930

Conversation

ndeloof commented Jun 11, 2025

Uh oh!

glours left a comment

Choose a reason for hiding this comment

Uh oh!

ndeloof commented Jun 11, 2025

Uh oh!

codecov bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jun 11, 2025 •

edited

Loading