Skip to content

Commit e4ed6b5

Browse files
committed
test digest or canonical reference, not only tag, when checking if an image is already present
Signed-off-by: Guillaume Lours <[email protected]>
1 parent e25265d commit e4ed6b5

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

pkg/compose/pull.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,18 @@ func imageAlreadyPresent(serviceImage string, localImages map[string]api.ImageSu
159159
if err != nil {
160160
return false
161161
}
162-
tagged, ok := normalizedImage.(reference.NamedTagged)
163-
if !ok {
164-
return false
162+
switch normalizedImage.(type) {
163+
case reference.NamedTagged:
164+
tagged, ok := normalizedImage.(reference.NamedTagged)
165+
if !ok {
166+
return false
167+
}
168+
_, ok = localImages[serviceImage]
169+
return ok && tagged.Tag() != "latest"
170+
default:
171+
_, ok := localImages[serviceImage]
172+
return ok
165173
}
166-
_, ok = localImages[serviceImage]
167-
return ok && tagged.Tag() != "latest"
168174
}
169175

170176
func getUnwrappedErrorMessage(err error) string {

0 commit comments

Comments
 (0)