Skip to content

Commit 1f006ae

Browse files
committed
propagate docker endpoint to bake using DOCKER_* env variables
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent 51499f6 commit 1f006ae

File tree

3 files changed

+61
-18
lines changed

3 files changed

+61
-18
lines changed

pkg/compose/build_bake.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,14 @@ func (s *composeService) doBuildBake(ctx context.Context, project *types.Project
335335
if err != nil {
336336
return nil, err
337337
}
338+
endpoint, cleanup, err := s.propagateDockerEndpoint()
339+
if err != nil {
340+
return nil, err
341+
}
342+
cmd.Env = append(cmd.Env, endpoint...)
343+
defer cleanup()
344+
345+
fmt.Println(strings.Join(cmd.Env, "\n"))
338346

339347
cmd.Stdout = s.stdout()
340348
cmd.Stdin = bytes.NewBuffer(b)

pkg/compose/model.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ func (s *composeService) ensureModels(ctx context.Context, project *types.Projec
4343
if err != nil {
4444
return err
4545
}
46+
defer api.Close()
4647
availableModels, err := api.ListModels(ctx)
4748

4849
eg, ctx := errgroup.WithContext(ctx)
@@ -72,6 +73,7 @@ type modelAPI struct {
7273
path string
7374
env []string
7475
prepare func(ctx context.Context, cmd *exec.Cmd) error
76+
cleanup func()
7577
}
7678

7779
func (s *composeService) newModelAPI(project *types.Project) (*modelAPI, error) {
@@ -82,15 +84,24 @@ func (s *composeService) newModelAPI(project *types.Project) (*modelAPI, error)
8284
}
8385
return nil, err
8486
}
87+
endpoint, cleanup, err := s.propagateDockerEndpoint()
88+
if err != nil {
89+
return nil, err
90+
}
8591
return &modelAPI{
8692
path: dockerModel.Path,
8793
prepare: func(ctx context.Context, cmd *exec.Cmd) error {
8894
return s.prepareShellOut(ctx, project.Environment, cmd)
8995
},
90-
env: project.Environment.Values(),
96+
cleanup: cleanup,
97+
env: append(project.Environment.Values(), endpoint...),
9198
}, nil
9299
}
93100

101+
func (m *modelAPI) Close() {
102+
m.cleanup()
103+
}
104+
94105
func (m *modelAPI) PullModel(ctx context.Context, model types.ModelConfig, quietPull bool, w progress.Writer) error {
95106
w.Event(progress.Event{
96107
ID: model.Name,

pkg/compose/shellout.go

Lines changed: 41 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,16 @@ package compose
1818

1919
import (
2020
"context"
21+
"os"
2122
"os/exec"
23+
"path/filepath"
2224

2325
"github.com/compose-spec/compose-go/v2/types"
2426
"github.com/docker/cli/cli-plugins/metadata"
25-
"github.com/docker/cli/cli/context/docker"
27+
"github.com/docker/cli/cli/command"
28+
"github.com/docker/cli/cli/flags"
2629
"github.com/docker/compose/v2/internal"
30+
"github.com/docker/docker/client"
2731
"go.opentelemetry.io/otel"
2832
"go.opentelemetry.io/otel/propagation"
2933
)
@@ -39,23 +43,43 @@ func (s *composeService) prepareShellOut(gctx context.Context, env types.Mapping
3943
otel.GetTextMapPropagator().Inject(gctx, &carrier)
4044
env.Merge(types.Mapping(carrier))
4145

42-
env["DOCKER_CONTEXT"] = s.dockerCli.CurrentContext()
46+
cmd.Env = env.Values()
47+
return nil
48+
}
49+
50+
// propagateDockerEndpoint produces DOCKER_* env vars for a child CLI plugin to target the same docker endpoint
51+
func (s *composeService) propagateDockerEndpoint() ([]string, func(), error) {
52+
cleanup := func() {}
53+
env := types.Mapping{}
54+
env[command.EnvOverrideContext] = s.dockerCli.CurrentContext()
4355
env["USER_AGENT"] = "compose/" + internal.Version
56+
endpoint := s.dockerCli.DockerEndpoint()
57+
env[client.EnvOverrideHost] = endpoint.Host
58+
if endpoint.TLSData != nil {
59+
certs, err := os.MkdirTemp("", "compose")
60+
if err != nil {
61+
return nil, cleanup, err
62+
}
63+
cleanup = func() {
64+
_ = os.RemoveAll(certs)
65+
}
66+
env[client.EnvOverrideCertPath] = certs
67+
if !endpoint.SkipTLSVerify {
68+
env[client.EnvTLSVerify] = "1"
69+
}
4470

45-
md, err := s.dockerCli.ContextStore().GetMetadata(s.dockerCli.CurrentContext())
46-
if err != nil {
47-
return err
48-
}
49-
endpoint, err := docker.EndpointFromContext(md)
50-
if err != nil {
51-
return err
71+
err = os.WriteFile(filepath.Join(certs, flags.DefaultKeyFile), endpoint.TLSData.Key, 0o600)
72+
if err != nil {
73+
return nil, cleanup, err
74+
}
75+
err = os.WriteFile(filepath.Join(certs, flags.DefaultCaFile), endpoint.TLSData.Cert, 0o600)
76+
if err != nil {
77+
return nil, cleanup, err
78+
}
79+
err = os.WriteFile(filepath.Join(certs, flags.DefaultCaFile), endpoint.TLSData.CA, 0o600)
80+
if err != nil {
81+
return nil, cleanup, err
82+
}
5283
}
53-
actualHost := s.dockerCli.DockerEndpoint().Host
54-
if endpoint.Host != actualHost {
55-
// We are running with `--host` or `DOCKER_HOST` which overrides selected context
56-
env["DOCKER_HOST"] = actualHost
57-
}
58-
59-
cmd.Env = env.Values()
60-
return nil
84+
return env.Values(), cleanup, nil
6185
}

0 commit comments

Comments
 (0)