Skip to content

Commit 71e525f

Browse files
committed
gometalinter: fix configuration
The configuration abused "Exclude" to exclude file-paths by filtering on the output, however, the `Skip` option was designed for that, whereas `Exclude` is for matching warnings. An explicit "Skip" was added for "vendor", because even though the vendor directory should already be ignored by the linter, in some situations, it still seemed to warn on issues, so let's explicitly ignore it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 146d29c commit 71e525f

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

gometalinter.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,16 @@
22
"Vendor": true,
33
"Deadline": "2m",
44
"Sort": ["linter", "severity", "path", "line"],
5-
"Exclude": [
5+
"Skip": [
66
"cli/compose/schema/bindata.go",
77
"cli/command/stack/kubernetes/api/openapi",
88
"cli/command/stack/kubernetes/api/client",
99
".*generated.*",
10-
"parameter .* always receives"
10+
"vendor"
11+
],
12+
"Exclude": [
13+
"parameter .* always receives",
14+
"_esc(Dir|FS|FSString|FSMustString) is unused"
1115
],
1216
"EnableGC": true,
1317
"Linters": {

0 commit comments

Comments
 (0)