Skip to content

Commit 4fceb95

Browse files
committed
otel: use context when initializing the tracer and meter provider
1 parent 0f9e229 commit 4fceb95

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

cli/command/telemetry.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,20 @@ type TelemetryClient interface {
4242
// TracerProvider returns a TracerProvider. This TracerProvider will be configured
4343
// with the default tracing components for a CLI program along with any options given
4444
// for the SDK.
45-
TracerProvider(opts ...sdktrace.TracerProviderOption) TracerProvider
45+
TracerProvider(ctx context.Context, opts ...sdktrace.TracerProviderOption) TracerProvider
4646

4747
// MeterProvider returns a MeterProvider. This MeterProvider will be configured
4848
// with the default metric components for a CLI program along with any options given
4949
// for the SDK.
50-
MeterProvider(opts ...sdkmetric.Option) MeterProvider
50+
MeterProvider(ctx context.Context, opts ...sdkmetric.Option) MeterProvider
5151
}
5252

5353
func (cli *DockerCli) Resource() *resource.Resource {
5454
return cli.res.Get()
5555
}
5656

57-
func (cli *DockerCli) TracerProvider(opts ...sdktrace.TracerProviderOption) TracerProvider {
58-
exp, err := dockerSpanExporter(cli)
57+
func (cli *DockerCli) TracerProvider(ctx context.Context, opts ...sdktrace.TracerProviderOption) TracerProvider {
58+
exp, err := dockerSpanExporter(ctx, cli)
5959
if err != nil {
6060
otel.Handle(err)
6161
}
@@ -66,8 +66,8 @@ func (cli *DockerCli) TracerProvider(opts ...sdktrace.TracerProviderOption) Trac
6666
return sdktrace.NewTracerProvider(append(defaultOpts, opts...)...)
6767
}
6868

69-
func (cli *DockerCli) MeterProvider(opts ...sdkmetric.Option) MeterProvider {
70-
exp, err := dockerMetricExporter(cli)
69+
func (cli *DockerCli) MeterProvider(ctx context.Context, opts ...sdkmetric.Option) MeterProvider {
70+
exp, err := dockerMetricExporter(ctx, cli)
7171
if err != nil {
7272
otel.Handle(err)
7373
}

cli/command/telemetry_docker.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func dockerExporterOtlpEndpoint(cli Cli) (endpoint string, secure bool, err erro
8080
return endpoint, secure, nil
8181
}
8282

83-
func dockerSpanExporter(cli Cli) (sdktrace.SpanExporter, error) {
83+
func dockerSpanExporter(ctx context.Context, cli Cli) (sdktrace.SpanExporter, error) {
8484
endpoint, secure, err := dockerExporterOtlpEndpoint(cli)
8585
if err != nil {
8686
return nil, err
@@ -93,14 +93,14 @@ func dockerSpanExporter(cli Cli) (sdktrace.SpanExporter, error) {
9393
opts = append(opts, otlptracegrpc.WithInsecure())
9494
}
9595

96-
exp, err := otlptracegrpc.New(context.Background(), opts...)
96+
exp, err := otlptracegrpc.New(ctx, opts...)
9797
if err != nil {
9898
return nil, err
9999
}
100100
return exp, nil
101101
}
102102

103-
func dockerMetricExporter(cli Cli) (sdkmetric.Exporter, error) {
103+
func dockerMetricExporter(ctx context.Context, cli Cli) (sdkmetric.Exporter, error) {
104104
endpoint, secure, err := dockerExporterOtlpEndpoint(cli)
105105
if err != nil {
106106
return nil, err
@@ -113,7 +113,7 @@ func dockerMetricExporter(cli Cli) (sdkmetric.Exporter, error) {
113113
opts = append(opts, otlpmetricgrpc.WithInsecure())
114114
}
115115

116-
exp, err := otlpmetricgrpc.New(context.Background(), opts...)
116+
exp, err := otlpmetricgrpc.New(ctx, opts...)
117117
if err != nil {
118118
return nil, err
119119
}

0 commit comments

Comments
 (0)