Remove now obsolete gometalinter and use golangci-lint instead with almost the same configuration.

Signed-off-by: Silvin Lubecki <[email protected]>

Author: silvin-lubecki

.golangci.yml

@@ -0,0 +1,35 @@
+run:
+  deadline: 3m
+  skip-dirs:
+    - cli/command/stack/kubernetes/api/openapi
+    - cli/command/stack/kubernetes/api/client
+  skip-files:
+    - cli/compose/schema/bindata.go
+    - .*generated.*
+    - parameter .* always receives
+linters:
+  disable-all: true
+  enable:
+    - deadcode
+    - gocyclo
+    - gofmt
+    - goimports
+    - golint
+    - gosimple
+    - ineffassign
+    - interfacer
+    - lll
+    - misspell
+    - nakedret
+    - unconvert
+    - unparam
+    - unused
+    - vet
+linters-settings:
+  nakedret:
+    command: nakedret
+    pattern: ^(?P<path>.*?\\.go):(?P<line>\\d+)\\s*(?P<message>.*)$
+  gocyclo:
+    min-complexity: 16
+  lll:
+    line-length: 200

dockerfiles/Dockerfile.lint

@@ -1,18 +1,15 @@
-FROM    golang:1.12.1-alpine
+FROM    golang:1.12.1 as build
+ARG     GOLANGCI_LINTER_SHA=v1.16.0
 
-RUN     apk add -U git
+ENV     CGO_ENABLED=0
+RUN     GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@$GOLANGCI_LINTER_SHA
 
-ARG     GOMETALINTER_SHA=v2.0.6
-RUN     go get -d github.com/alecthomas/gometalinter && \
-        cd /go/src/github.com/alecthomas/gometalinter && \
-        git checkout -q "$GOMETALINTER_SHA" && \
-        go build -v -o /usr/local/bin/gometalinter . && \ 
-        gometalinter --install && \
-        rm -rf /go/src/* /go/pkg/*
+FROM golang:1.12.1-alpine as lint
 
+COPY --from=build /go/bin/golangci-lint /usr/local/bin
 WORKDIR /go/src/github.com/docker/cli
-ENV     CGO_ENABLED=0
 ENV     DISABLE_WARN_OUTSIDE_CONTAINER=1
-ENTRYPOINT ["/usr/local/bin/gometalinter"]
-CMD     ["--config=gometalinter.json", "./..."]
+ENV     CGO_ENABLED=0
+ENTRYPOINT ["/usr/local/bin/golangci-lint"]
+CMD     ["--verbose", "run", "--config=.golangci.yml"]
 COPY    . .