Skip to content

driver/kubernetes/context: don't use ResolveDefaultContext in test #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

driver/kubernetes/context: don't use ResolveDefaultContext in test #3444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions driver/kubernetes/context/load_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,20 @@ import (

func TestDefaultContextInitializer(t *testing.T) {
t.Setenv("KUBECONFIG", "./fixtures/test-kubeconfig")
ctx, err := command.ResolveDefaultContext(&cliflags.ClientOptions{}, command.DefaultContextStoreConfig())
dockerCLI, err := command.NewDockerCli()
require.NoError(t, err)
assert.Equal(t, "default", ctx.Meta.Name)
assert.Equal(t, "zoinx", ctx.Meta.Endpoints[KubernetesEndpoint].(EndpointMeta).DefaultNamespace)

// FIXME(thaJeztah): the context-store is not initialized until "Initialize" is called.
err = dockerCLI.Initialize(cliflags.NewClientOptions())
require.NoError(t, err)
Comment on lines +19 to +21
Copy link
Member Author

@thaJeztah thaJeztah Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to have a look at this; the whole CLI (and CLI-plugin) bootstrapping is really involved. IMO, the CLI should be in a usable state after NewDockerCLI, but need to check if everything CAN be initialised in that constructor due to some of the oddities with flag parsing and top-level flags;

If we can't initialise in the NewDockerCli constructor, perhaps we can add some lazy constructor for the ContextStore() to at least prevent it returning nil (and panic in this test 😂)


cs := dockerCLI.ContextStore()
assert.NotNil(t, cs)
meta, err := cs.GetMetadata(command.DefaultContextName)
require.NoError(t, err)

assert.Equal(t, "default", meta.Name)
assert.Equal(t, "zoinx", meta.Endpoints[KubernetesEndpoint].(EndpointMeta).DefaultNamespace)
}

func TestConfigFromEndpoint(t *testing.T) {
Expand Down