vendor: github.com/docker/docker and github.com/docker/cli v26.0.0 #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Mar 27, 2024
|
|
||
| if !opts.force { | ||
| if ok, err := prompt(ctx, dockerCli.In(), dockerCli.Out(), warning); err != nil { | ||
| if ok, err := command.PromptForConfirmation(ctx, dockerCli.In(), dockerCli.Out(), warning); err != nil { |
Member
There was a problem hiding this comment.
The current version can't be used because it sets up own signal handlers internally that would mess up the buildx own signal handlers. See docker/cli#4888 (review)
We need to do some copy-paste of the old/forked code to work around.
Signed-off-by: CrazyMax <[email protected]>
tonistiigi
requested changes
Mar 29, 2024
|
|
||
| if !opts.force { | ||
| if ok, err := prompt(ctx, dockerCli.In(), dockerCli.Out(), warning); err != nil { | ||
| if ok, err := command.PromptForConfirmation(ctx, dockerCli.In(), dockerCli.Out(), warning); err != nil { |
Member
There was a problem hiding this comment.
The current version can't be used because it sets up own signal handlers internally that would mess up the buildx own signal handlers. See docker/cli#4888 (review)
We need to do some copy-paste of the old/forked code to work around.
Member
|
superseded by #2372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump docker to 26.0.0 in the dockerfile for integration tests as well.