Skip to content

Commit 335acca

Browse files
committed
Fixes for new printer APIs
Signed-off-by: Kohei Tokunaga <[email protected]>
1 parent 1a4b2c6 commit 335acca

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

commands/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ func runControllerBuild(ctx context.Context, dockerCli command.Cli, opts *contro
371371
return nil
372372
})
373373

374-
if options.invoke != nil && options.invoke.invokeFlag == "debug-step" {
374+
if options.invokeConfig != nil && options.invokeConfig.invokeFlag == "debug-step" {
375375
// Special mode where we don't get the result but get only the build definition.
376376
// In this mode, Build() doesn't perform the build therefore always fails.
377377
opts.Debug = true

monitor/dap/dap.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
"github.com/moby/buildkit/identity"
3737
"github.com/moby/buildkit/solver/errdefs"
3838
"github.com/moby/buildkit/solver/pb"
39+
"github.com/moby/buildkit/util/progress/progressui"
3940
"github.com/pkg/errors"
4041
"github.com/sirupsen/logrus"
4142
"github.com/urfave/cli"
@@ -375,7 +376,7 @@ func (s *Server) launchDebugger(cfg LaunchConfig) (retErr error) {
375376
}
376377
}()
377378
var printer *progress.Printer
378-
printer, err = progress.NewPrinter(ctx, s.outputStdoutWriter(), nil, "plain",
379+
printer, err = progress.NewPrinter(ctx, s.outputStdoutWriter(), progressui.PlainMode,
379380
progress.WithOnClose(func() {
380381
printWarnings(s.outputStdoutWriter(), printer.Warnings())
381382
}),

util/progress/printer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ package progress
22

33
import (
44
"context"
5+
"io"
56
"os"
67
"sync"
78

8-
"github.com/containerd/console"
99
"github.com/docker/buildx/util/logutil"
1010
"github.com/moby/buildkit/client"
1111
"github.com/moby/buildkit/util/progress/progressui"
@@ -80,7 +80,7 @@ func (p *Printer) ClearLogSource(v interface{}) {
8080
}
8181
}
8282

83-
func NewPrinter(ctx context.Context, out console.File, mode progressui.DisplayMode, opts ...PrinterOpt) (*Printer, error) {
83+
func NewPrinter(ctx context.Context, out io.Writer, mode progressui.DisplayMode, opts ...PrinterOpt) (*Printer, error) {
8484
opt := &printerOpts{}
8585
for _, o := range opts {
8686
o(opt)

0 commit comments

Comments
 (0)