move to nodenext and simplify TS/ESM config

Signed-off-by: CrazyMax <[email protected]>

Author: crazy-max

eslint.config.cjs

@@ -36,16 +36,7 @@ module.exports = defineConfig([
   globalIgnores(['.yarn/**/*', 'lib/**/*', 'coverage/**/*', 'node_modules/**/*']),
   {
     extends: fixupConfigRules(
-      compat.extends(
-        'eslint:recommended',
-        'plugin:@typescript-eslint/eslint-recommended',
-        'plugin:@typescript-eslint/recommended',
-        'plugin:import/errors',
-        'plugin:import/typescript',
-        'plugin:import/warnings',
-        'plugin:vitest/recommended',
-        'plugin:prettier/recommended'
-      )
+      compat.extends('eslint:recommended', 'plugin:@typescript-eslint/eslint-recommended', 'plugin:@typescript-eslint/recommended', 'plugin:import/errors', 'plugin:import/typescript', 'plugin:import/warnings', 'plugin:prettier/recommended')
     ),
 
     plugins: {
@@ -75,9 +66,10 @@ module.exports = defineConfig([
       'import/no-unresolved': [
         'error',
         {
-          ignore: ['\\.js$', 'csv-parse/sync', '@octokit/openapi-types', '@octokit/core', '@octokit/plugin-rest-endpoint-methods']
+          ignore: ['\\.js$', 'csv-parse/sync', '@octokit/openapi-types', '@octokit/core', '@octokit/plugin-rest-endpoint-methods', 'vitest/config']
         }
       ],
+      'vitest/no-conditional-expect': 'error',
       'vitest/no-disabled-tests': 0
     }
   }

src/github/artifact.ts

@@ -17,17 +17,17 @@
 import crypto from 'crypto';
 import fs from 'fs';
 import path from 'path';
-import {CreateArtifactRequest, FinalizeArtifactRequest, StringValue} from '@actions/artifact/lib/generated';
-import {internalArtifactTwirpClient} from '@actions/artifact/lib/internal/shared/artifact-twirp-client';
-import {getBackendIdsFromToken} from '@actions/artifact/lib/internal/shared/util';
-import {getExpiration} from '@actions/artifact/lib/internal/upload/retention';
+import {CreateArtifactRequest, FinalizeArtifactRequest, StringValue} from '@actions/artifact/lib/generated/index.js';
+import {internalArtifactTwirpClient} from '@actions/artifact/lib/internal/shared/artifact-twirp-client.js';
+import {getBackendIdsFromToken} from '@actions/artifact/lib/internal/shared/util.js';
+import {getExpiration} from '@actions/artifact/lib/internal/upload/retention.js';
 import {InvalidResponseError, NetworkError} from '@actions/artifact';
 import * as core from '@actions/core';
 import {TransferProgressEvent} from '@azure/core-rest-pipeline';
 import {BlobClient, BlobHTTPHeaders} from '@azure/storage-blob';
 
 import {UploadOpts, UploadResponse} from '../types/github/artifact.js';
-import {GitHub} from './github';
+import {GitHub} from './github.js';
 
 export class GitHubArtifact {
   public static async upload(opts: UploadOpts): Promise<UploadResponse> {

src/github/summary.ts

@@ -19,7 +19,7 @@ import {dump as yamldump} from 'js-yaml';
 import os from 'os';
 import * as core from '@actions/core';
 
-import {GitHub} from './github';
+import {GitHub} from './github.js';
 import {Util} from '../util.js';
 
 import {BuildSummaryOpts, SummaryTableCell} from '../types/github/summary.js';

src/types/github/summary.ts

@@ -16,9 +16,9 @@
 
 import * as core from '@actions/core';
 
-import {UploadResponse} from './artifact';
-import {BakeDefinition} from '../buildx/bake';
-import {ExportResponse} from '../buildx/history';
+import {UploadResponse} from './artifact.js';
+import {BakeDefinition} from '../buildx/bake.js';
+import {ExportResponse} from '../buildx/history.js';
 
 export type SummaryTableRow = Parameters<typeof core.summary.addTable>[0][number];
 export type SummaryTableCell = Exclude<SummaryTableRow[number], string>;

tsconfig.json

@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
-    "module": "es2020",
-    "moduleResolution": "bundler",
+    "module": "nodenext",
+    "moduleResolution": "nodenext",
     "esModuleInterop": true,
     "isolatedModules": true,
     "strict": true,
@@ -12,13 +12,13 @@
     "rootDir": "./src",
     "forceConsistentCasingInFileNames": true,
     "noImplicitAny": false,
-    "resolveJsonModule": true,
     "useUnknownInCatchVariables": false,
-    "skipLibCheck": true,
+    "skipLibCheck": true
   },
+  "include": [
+    "src/**/*.ts"
+  ],
   "exclude": [
-    "./__mocks__/**/*",
-    "./__tests__/**/*",
     "./lib/**/*",
     "node_modules"
   ]