Feature/wysiwyg editors #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
eluhr
requested changes
Apr 30, 2024
src/JoditAsset.php
Outdated
|
|
||
| class JoditAsset extends AssetBundle | ||
| { | ||
| public $sourcePath = '@dmstr/jsoneditor/assets/'; |
Collaborator
There was a problem hiding this comment.
Use @dmstr/jsoneditor/assets/jodit here to prevent publishing unwanted files
Collaborator
There was a problem hiding this comment.
Or why do we not use the files in /assets/jodit
src/SceditorAsset.php
Outdated
|
|
||
| class SceditorAsset extends AssetBundle | ||
| { | ||
| public $sourcePath = '@dmstr/jsoneditor/assets/sceditor/minified'; |
Collaborator
There was a problem hiding this comment.
why do we not use the files in /assets/sceditor/minified?
src/JsonEditorWidget.php
Outdated
| } | ||
| }'; | ||
|
|
||
| $json = Yii::$app->settings->getOrSet('jodit.config', $joditConfig, 'jsoneditor', 'object'); |
Collaborator
|
Why are the assets bundles not in the |
Collaborator
Author
|
Ping |
schmunk42
requested changes
May 6, 2024
Member
schmunk42
left a comment
schmunk42
left a comment
There was a problem hiding this comment.
Please include the LICENSE files and a note in the README about the bundled assets.
schmunk42
approved these changes
May 7, 2024
Collaborator
Author
|
This pull request is no longer WIP. Should i merge and tag? |
Member
|
Yes, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatives for CKEditor: Jodit and SCEditor
Markdown editor: simpleMDE