Skip to content

Conversation

@trivialfis
Copy link
Member

Nice to have. However, let's not include it in the support matrix.

@trivialfis trivialfis requested a review from Copilot September 27, 2025 03:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the WebAssembly (WASM) build by addressing compatibility issues with the Emscripten toolchain. The changes focus on resolving type conversion issues and disabling thread-related dependencies that are not supported in WASM environments.

  • Explicit type annotations to resolve implicit conversions that fail in WASM builds
  • Conditional compilation to exclude threading support for Emscripten builds
  • CMake configuration updates to handle WASM-specific requirements

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/common/threading_utils.h Adds explicit type annotation for block_beg variable
src/c_api/c_api.cc Refactors buffer creation with explicit type aliases and casts
cmake/Utils.cmake Conditionally excludes thread linking for Emscripten builds
CMakeLists.txt Conditionally excludes thread package finding for Emscripten builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@trivialfis trivialfis requested a review from hcho3 September 27, 2025 07:01
@trivialfis trivialfis merged commit a3a5786 into dmlc:master Sep 29, 2025
63 checks passed
@trivialfis trivialfis deleted the fix-wasm branch September 29, 2025 16:12
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Sep 30, 2025
trivialfis added a commit that referenced this pull request Sep 30, 2025
@trivialfis trivialfis mentioned this pull request Sep 30, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants