-
-
Notifications
You must be signed in to change notification settings - Fork 4k
docs: add missing, fix existing #10842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10842 +/- ##
==========================================
+ Coverage 42.75% 42.78% +0.03%
==========================================
Files 262 262
Lines 16079 16076 -3
Branches 1548 1566 +18
==========================================
+ Hits 6874 6878 +4
+ Misses 9193 9186 -7
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
181b918 to
30932f4
Compare
packages/builders/src/interactions/commands/chatInput/options/attachment.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/boolean.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/channel.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/integer.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/mentionable.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/number.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/role.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/string.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/user.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates documentation and internal annotations across various builder classes while also standardizing construction logic to avoid unnecessary cloning of data. Key changes include adding missing documentation/comments (e.g., @internal and @mixes tags), refining constructor parameter handling, and minor refactors to improve code clarity.
Reviewed Changes
Copilot reviewed 60 out of 60 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/builders/src/components/v2/Separator.ts | Added jsdoc for the builder and marked internal properties |
| packages/builders/src/components/v2/Section.ts | Updated docs and refined accessor conversion for the accessory property |
| packages/builders/src/components/v2/MediaGalleryItem.ts | Simplified constructor assignment to avoid an unnecessary spread clone |
| packages/builders/src/components/v2/MediaGallery.ts | Added getter for items and adjusted data cloning logic |
| packages/builders/src/components/v2/File.ts | Modified constructor to destructure file property before cloning data |
| packages/builders/src/components/v2/Container.ts | Introduced a getter for components and standardized constructor handling |
| Remaining files | Primarily doc comment updates and improved internal annotations |
packages/builders/src/interactions/commands/chatInput/options/string.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/channel.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/integer.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/chatInput/options/number.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/commands/contextMenu/ContextMenuCommand.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Qjuh <[email protected]>
@internal@mixestags