refactor(FetchApplicationCommandOptions): Use Locale over LocaleString (#10625)

refactor(FetchApplicationCommandOptions): prefer `Locale`

Author: Jiralite

packages/discord.js/src/managers/ApplicationCommandManager.js

@@ -82,7 +82,7 @@ class ApplicationCommandManager extends CachedManager {
    * Options used to fetch Application Commands from Discord
    * @typedef {BaseFetchOptions} FetchApplicationCommandOptions
    * @property {Snowflake} [guildId] The guild's id to fetch commands for, for when the guild is not cached
-   * @property {LocaleString} [locale] The locale to use when fetching this command
+   * @property {Locale} [locale] The locale to use when fetching this command
    * @property {boolean} [withLocalizations] Whether to fetch all localization data
    */
 

packages/discord.js/src/util/APITypes.js

@@ -475,11 +475,6 @@
  * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/Locale}
  */
 
-/**
- * @external LocaleString
- * @see {@link https://discord-api-types.dev/api/discord-api-types-v10#LocaleString}
- */
-
 /**
  * @external MessageActivityType
  * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/MessageActivityType}

packages/discord.js/typings/index.d.ts

@@ -126,7 +126,6 @@ import {
   APIEmbedImage,
   VideoQualityMode,
   LocalizationMap,
-  LocaleString,
   MessageActivityType,
   APIAttachment,
   APIChannel,
@@ -5814,7 +5813,7 @@ export type EmojiResolvable = Snowflake | GuildEmoji | ReactionEmoji | Applicati
 
 export interface FetchApplicationCommandOptions extends BaseFetchOptions {
   guildId?: Snowflake;
-  locale?: LocaleString;
+  locale?: Locale;
   withLocalizations?: boolean;
 }