fix(APIGuildMember): make user required and omit in messages #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
advaith1
added a commit
to polynomial115/polynomial-client
that referenced
this pull request
Jun 5, 2024
vladfrangu
previously requested changes
Jun 5, 2024
Member
vladfrangu
left a comment
vladfrangu
left a comment
There was a problem hiding this comment.
Please name the test file in the same pattern as the other files (so name.test-d.ts)
Contributor
Author
|
oops i thought i did that. fixed |
almeidx
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
useris optional on APIGuildMember, but the only case it isn't present is in the message gateway events, because those have message.author so message.member.user would be redundant. This leads to a bad experience when using other member objects, sinceuserwill be there but the optionality needs to be handled.This PR sets
userrequired in APIGuildMember, and omits it where it is not present (GatewayMessageEventExtraFields).