Skip to content

Conversation

@AtoraSuunva
Copy link
Contributor

@AtoraSuunva AtoraSuunva commented Mar 21, 2024

Please describe the changes this PR makes and why it should be merged:

Adds in the new fields & deprecation changes from https://discord.com/developers/docs/change-log#userinstallable-apps-preview

Now you can make user-installable apps with type-safety :)

Marked as draft until these issues are resolved, since what the API returns and what the docs say is different (current PR matches the API, will update based on issues):

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:05am

- integration_types is always optional
- contexts is always optional
- contexts is nullable except when creating or editing an application command
@kyranet
Copy link
Member

kyranet commented May 4, 2024

The last issue just got resolved. 👀

- Remove non-string value in `authorizing_integration_owners`
- Preserve documentation for `contexts`
- `APIMessageInteractionMetadata` `user_id` -> `user`
@AtoraSuunva
Copy link
Contributor Author

Types now match the API and docs.

I'm unsure if this should be merged (as the docs say: "API details are subject to change.") but I'll leave it up to the maintainers to decide.

If not yet, I'll keep this updated with changes.

@AtoraSuunva AtoraSuunva marked this pull request as ready for review May 4, 2024 12:38
@AtoraSuunva AtoraSuunva requested review from a team as code owners May 4, 2024 12:38
@kyranet
Copy link
Member

kyranet commented May 4, 2024

You can mark it as @unstable in that case.

@AtoraSuunva
Copy link
Contributor Author

Is this an API v10 only feature? If yes, please let us know! If not, ctrl c ctrl v in api v9 too please

Seems to work even all the way back to v6, both REST requests and gateway. Only added it to v9 for now though.

@vladfrangu
Copy link
Member

Lets see if crap hits the fan >:3

@vladfrangu vladfrangu merged commit c457b8d into discordjs:main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants