Fix a bug in EmbedBuilder.Length when there is an EmbedField with no Value (#2345)

Hampo · quinchs · web-flow · commit 2b86a79f7008 · 2022-09-04T06:46:50.000Z
* Update EmbedBuilder.cs

Fixes a bug where 'EmbedBuilder.Length' will throw an exception of type 'System.NullReferenceException' when a field doesn't have a value.

* Update EmbedBuilder.cs

Fixed an incorrect assuption that `Value` was a `string?`

* Update EmbedBuilder.cs

Fixed one more null check

* Update EmbedBuilder.cs

Co-authored-by: Quin Lynch &lt;49576606+quinchs@users.noreply.github.com&gt;
diff --git a/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs b/src/Discord.Net.Core/Entities/Messages/EmbedBuilder.cs
@@ -150,7 +150,7 @@ public int Length
                 int authorLength = Author?.Name?.Length ?? 0;
                 int descriptionLength = Description?.Length ?? 0;
                 int footerLength = Footer?.Text?.Length ?? 0;
-                int fieldSum = Fields.Sum(f => f.Name.Length + f.Value.ToString().Length);
+                int fieldSum = Fields.Sum(f => f.Name.Length + (f.Value?.ToString()?.Length ?? 0));
 
                 return titleLength + authorLength + descriptionLength + footerLength + fieldSum;
             }

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ public int Length`
`150`	`150`	`int authorLength = Author?.Name?.Length ?? 0;`
`151`	`151`	`int descriptionLength = Description?.Length ?? 0;`
`152`	`152`	`int footerLength = Footer?.Text?.Length ?? 0;`
`153`		`- int fieldSum = Fields.Sum(f => f.Name.Length + f.Value.ToString().Length);`
	`153`	`+ int fieldSum = Fields.Sum(f => f.Name.Length + (f.Value?.ToString()?.Length ?? 0));`
`154`	`154`
`155`	`155`	`return titleLength + authorLength + descriptionLength + footerLength + fieldSum;`
`156`	`156`	`}`