Readme update and adjustments to trigger request and node IO#7
Merged
bryantgillespie merged 2 commits intomasterfrom Dec 5, 2025
Merged
Readme update and adjustments to trigger request and node IO#7bryantgillespie merged 2 commits intomasterfrom
bryantgillespie merged 2 commits intomasterfrom
Conversation
… IO with NodeConnectionTypes.Main
There was a problem hiding this comment.
Pull request overview
This PR modernizes the authentication approach and improves code maintainability by replacing manual authentication headers with n8n's built-in authenticated request helper, updating node I/O types to use the proper enum constant, switching from process forks to threads in testing configuration, and simplifying the README by removing outdated development documentation.
- Replaced
httpRequestwithhttpRequestWithAuthenticationthroughout webhook methods, leveraging credential-based authentication - Updated node inputs/outputs from string literals to
NodeConnectionTypes.Mainenum - Changed Vitest pool configuration from 'forks' to 'threads' for better test execution
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Switched test pool from 'forks' to 'threads' with corresponding option updates |
| nodes/DirectusTrigger/methods/webhookMethods.ts | Replaced all httpRequest calls with httpRequestWithAuthentication, removing manual Authorization headers |
| nodes/Directus/Directus.node.ts | Updated inputs/outputs to use NodeConnectionTypes.Main enum instead of string literals |
| tests/helpers.ts | Added mock implementation for httpRequestWithAuthentication helper method |
| tests/DirectusTrigger.node.test.ts | Updated test assertions to use new method name and correct argument indexing (call[1] instead of call[0]) |
| tests/Directus.node.test.ts | Fixed indentation/formatting of file operation test cases |
| README.md | Removed outdated development documentation sections and troubleshooting content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bryantgillespie
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: