Skip to content

Readme update and adjustments to trigger request and node IO#7

Merged
bryantgillespie merged 2 commits intomasterfrom
readme-update
Dec 5, 2025
Merged

Readme update and adjustments to trigger request and node IO#7
bryantgillespie merged 2 commits intomasterfrom
readme-update

Conversation

@LZylstra
Copy link
Contributor

@LZylstra LZylstra commented Dec 4, 2025

Addresses:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the authentication approach and improves code maintainability by replacing manual authentication headers with n8n's built-in authenticated request helper, updating node I/O types to use the proper enum constant, switching from process forks to threads in testing configuration, and simplifying the README by removing outdated development documentation.

  • Replaced httpRequest with httpRequestWithAuthentication throughout webhook methods, leveraging credential-based authentication
  • Updated node inputs/outputs from string literals to NodeConnectionTypes.Main enum
  • Changed Vitest pool configuration from 'forks' to 'threads' for better test execution

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vitest.config.ts Switched test pool from 'forks' to 'threads' with corresponding option updates
nodes/DirectusTrigger/methods/webhookMethods.ts Replaced all httpRequest calls with httpRequestWithAuthentication, removing manual Authorization headers
nodes/Directus/Directus.node.ts Updated inputs/outputs to use NodeConnectionTypes.Main enum instead of string literals
tests/helpers.ts Added mock implementation for httpRequestWithAuthentication helper method
tests/DirectusTrigger.node.test.ts Updated test assertions to use new method name and correct argument indexing (call[1] instead of call[0])
tests/Directus.node.test.ts Fixed indentation/formatting of file operation test cases
README.md Removed outdated development documentation sections and troubleshooting content

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bryantgillespie bryantgillespie merged commit 54acffb into master Dec 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants