PR feedback updates

Author: LZylstra

__tests__/helpers.ts

@@ -7,14 +7,6 @@ export function mockDirectusCredentials() {
 	};
 }
 
-export function mockSuccessfulHttpRequest(data: any) {
-	return vi.fn<any>().mockResolvedValue({ data });
-}
-
-export function mockFailedHttpRequest(error: string) {
-	return vi.fn<any>().mockRejectedValue(new Error(error));
-}
-
 export function createMockExecuteFunctions(
 	options: {
 		nodeParameters: any;

credentials/DirectusApi.credentials.ts

@@ -43,23 +43,6 @@ export class DirectusApi implements ICredentialType {
 				'Without sufficient permissions, you may encounter 403 Forbidden errors when using this integration.',
 			required: true,
 		},
-		{
-			displayName: 'Environment',
-			name: 'environment',
-			type: 'options',
-			options: [
-				{
-					name: 'Cloud',
-					value: 'cloud',
-				},
-				{
-					name: 'Self-hosted',
-					value: 'self-hosted',
-				},
-			],
-			default: 'cloud',
-			description: 'The type of Directus instance you are connecting to',
-		},
 	];
 
 	authenticate: IAuthenticateGeneric = {

nodes/Directus/methods/utils.ts

@@ -1,6 +1,6 @@
 import type { IExecuteFunctions } from 'n8n-workflow';
 import { NodeOperationError } from 'n8n-workflow';
-import type { FieldParameter, DirectusField } from '../types';
+import type { FieldParameter } from '../types';
 
 export function buildRequestBody(fieldParams: FieldParameter | undefined): Record<string, unknown> {
 	const body: Record<string, unknown> = {};
@@ -16,18 +16,6 @@ export function buildRequestBody(fieldParams: FieldParameter | undefined): Recor
 	return body;
 }
 
-export function shouldSkipField(field: DirectusField): boolean {
-	if (!field?.meta) return true;
-	const special = field.meta.special || [];
-	return (
-		special.includes('m2a') ||
-		field.meta.locked ||
-		field.meta.hidden ||
-		field.type === 'alias' ||
-		field.field?.startsWith('$')
-	);
-}
-
 export function formatFieldName(input: string): string {
 	if (!input) return '';
 	return input.replace(/_/g, ' ').replace(/\b\w/g, (l) => l.toUpperCase());

nodes/Directus/types.ts

@@ -3,7 +3,6 @@ import type { IExecuteFunctions } from 'n8n-workflow';
 export interface DirectusCredentials {
 	url: string;
 	token: string;
-	environment: 'cloud' | 'self-hosted';
 }
 
 export interface DirectusRelation {
@@ -182,3 +181,12 @@ export interface IExecuteFunctionsWithRequest extends IExecuteFunctions {
 		request: (options: IRequestOptionsWithFormData) => Promise<unknown>;
 	};
 }
+
+export interface DirectusWebhookPayload {
+	event: string;
+	payload: Record<string, unknown>;
+	collection?: string;
+	key?: string;
+	id?: string;
+	keys?: string[];
+}