Append ROCm flag to compile definitions for Python instead of overwriting (facebookresearch#3742)

ramilbakhshyiev · facebook-github-bot · commit 962d747544b9 · 2024-08-09T02:04:53.000-07:00
Summary: Pull Request resolved: facebookresearch#3742 Before this change, the CMake line was setting (instead of appending to) compile definitions for Python code which replace the GPU wrappers flag and resulting in Python library compiling with no GPU code which failed ROCm tests. Reviewed By: junjieqi Differential Revision: D61007640 fbshipit-source-id: 174aeb0a4abe0607629ddf57c882d19ea2d6c6bf
diff --git a/faiss/python/CMakeLists.txt b/faiss/python/CMakeLists.txt
@@ -39,7 +39,7 @@ macro(configure_swigfaiss source)
       COMPILE_DEFINITIONS GPU_WRAPPER
     )
     if (FAISS_ENABLE_ROCM)
-      set_source_files_properties(${source} PROPERTIES
+      set_property(SOURCE ${source} APPEND PROPERTY
         COMPILE_DEFINITIONS FAISS_ENABLE_ROCM
       )
     endif()

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ macro(configure_swigfaiss source)`
`39`	`39`	`COMPILE_DEFINITIONS GPU_WRAPPER`
`40`	`40`	`)`
`41`	`41`	`if (FAISS_ENABLE_ROCM)`
`42`		`- set_source_files_properties(${source} PROPERTIES`
	`42`	`+ set_property(SOURCE ${source} APPEND PROPERTY`
`43`	`43`	`COMPILE_DEFINITIONS FAISS_ENABLE_ROCM`
`44`	`44`	`)`
`45`	`45`	`endif()`