Commit 476b0c2
fix bug: IVFPQ of raft/cuvs does not require redundant check (facebookresearch#4241)
Summary:
The IVFPQ of raft/cuvs does not require pq length check for Faiss' original implementation. This check make IVFPQ support limited parameters than raft/cuvs in vain.
The check of supported PQ code length here
https://github.com/facebookresearch/faiss/blob/ede2c99137efed18150839c07796e0856faec383/faiss/gpu/impl/IVFPQ.cu#L80-L102
is for Faiss' original CUDA implementation. Raft/cuvs support more choices.
The wiki of faiss also describe the limitation (https://github.com/facebookresearch/faiss/wiki/Faiss-on-the-GPU#limitations), which needs to be update, too. Raft/cuvs is not limited to those choices.
Pull Request resolved: facebookresearch#4241
Reviewed By: bshethmeta, gtwang01
Differential Revision: D72200376
Pulled By: mnorris11
fbshipit-source-id: 2b81e822a397f3ab4a7c691e38be0186535d129d1 parent 545ca58 commit 476b0c2
1 file changed
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
566 | 566 | | |
567 | 567 | | |
568 | 568 | | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
580 | 576 | | |
581 | 577 | | |
582 | 578 | | |
| |||
0 commit comments