fix a serialization problem in RaBitQ (facebookresearch#4261)

alexanderguzhva · facebook-github-bot · commit 1cb4c70a5bc9 · 2025-03-31T22:00:35.000-07:00
Summary: it seems that facebookresearch@2937f94 was not included in facebookresearch#4235. This PR fixes this problem. junjieqi Pull Request resolved: facebookresearch#4261 Reviewed By: gtwang01 Differential Revision: D72180816 Pulled By: junjieqi fbshipit-source-id: 55e156a3499fda6f8cdbb99ed941a3cbdd721417
diff --git a/faiss/impl/index_read.cpp b/faiss/impl/index_read.cpp
@@ -580,6 +580,7 @@ static void read_RaBitQuantizer(RaBitQuantizer* rabitq, IOReader* f) {
     // don't care about rabitq->centroid
     READ1(rabitq->d);
     READ1(rabitq->code_size);
+    READ1(rabitq->metric_type);
 }
 
 void read_direct_map(DirectMap* dm, IOReader* f) {
diff --git a/faiss/impl/index_write.cpp b/faiss/impl/index_write.cpp
@@ -370,6 +370,7 @@ static void write_RaBitQuantizer(const RaBitQuantizer* rabitq, IOWriter* f) {
     // don't care about rabitq->centroid
     WRITE1(rabitq->d);
     WRITE1(rabitq->code_size);
+    WRITE1(rabitq->metric_type);
 }
 
 static void write_direct_map(const DirectMap* dm, IOWriter* f) {

Original file line number	Diff line number	Diff line change
`@@ -580,6 +580,7 @@ static void read_RaBitQuantizer(RaBitQuantizer* rabitq, IOReader* f) {`
`580`	`580`	`// don't care about rabitq->centroid`
`581`	`581`	`READ1(rabitq->d);`
`582`	`582`	`READ1(rabitq->code_size);`
	`583`	`+ READ1(rabitq->metric_type);`
`583`	`584`	`}`
`584`	`585`
`585`	`586`	`void read_direct_map(DirectMap* dm, IOReader* f) {`
Original file line number	Diff line number	Diff line change
`@@ -370,6 +370,7 @@ static void write_RaBitQuantizer(const RaBitQuantizer* rabitq, IOWriter* f) {`
`370`	`370`	`// don't care about rabitq->centroid`
`371`	`371`	`WRITE1(rabitq->d);`
`372`	`372`	`WRITE1(rabitq->code_size);`
	`373`	`+ WRITE1(rabitq->metric_type);`
`373`	`374`	`}`
`374`	`375`
`375`	`376`	`static void write_direct_map(const DirectMap* dm, IOWriter* f) {`