Skip to content

Conversation

@PradnyaC11
Copy link

@PradnyaC11 PradnyaC11 commented Feb 25, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

https://diging.atlassian.net/browse/CITE-163
We need a bulk upload for files.

...Put description here...
The user would create a BibText export that includes files via Zotero (Zotero -> export collection -> BibTex format with "include files" checked). They would then zip the folder that Zotero exports and upload it to Citesphere. Citesphere would send it to the Citesphere Importer component (via Kafka like the other imports) and the importer would then create references in the zotero group the user specifies for the import (like for the web of science import that has no files) and send the files to Giles for processing (similar to how Giles sends individual files to Giles for processing).

Anything else the reviewer needs to know?

... describe here ...

public final static String REFERENCES_EXPORT_TOPIC = "_citesphere_export_references_topic";
public final static String REFERENCES_EXPORT_DONE_TOPIC = "_citesphere_export_references_done_topic";

public final static String COLLECTION_IMPORT_TOPIC = "_citesphere_import_collections_topic";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add javadoc here explaining what this topic is used for (it's starting to get less intuitively understandable).

@jdamerow jdamerow closed this Apr 29, 2025
@PradnyaC11 PradnyaC11 reopened this May 2, 2025
@PradnyaC11 PradnyaC11 requested a review from jdamerow May 2, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants