Go 1.12.0 + dep 0.5.0 + golangci-lint 1.15.0

Author: dictav

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.11.5
+FROM golang:1.12.0
 
 # prepare to install git-lfs
 RUN curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash
@@ -32,6 +32,7 @@ RUN curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh \
   && go get github.com/haya14busa/gosum/cmd/gosumcheck \
   && go get github.com/TeamMomentum/go-bindata/go-bindata
 
-# gometalinter
-RUN sh -c 'curl -L https://git.io/vp6lP | sh'
-COPY gometalinter.json /gometalinter.json
+# golangci-lint
+RUN sh -c "curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin"
+RUN golangci-lint --version
+COPY golangci.yml /golangci.yml

Makefile

@@ -7,5 +7,5 @@
 - gcloud
 - go tools
   - github.com/golang/dep
-  - github.com/alecthomas/gometalinter
+  - github.com/golangci/golangci-lint
   - github.com/haya14busa/gosum/cmd/gosumcheck

README.md

@@ -0,0 +1,36 @@
+run:
+  skip-dirs:
+
+  skip-files:
+
+linters:
+  enable-all: true
+  disable:
+    - gochecknoglobals
+    - gochecknoinits
+    - lll
+
+linters-settings:
+  dupl:
+    threshold: 50
+  govet:
+    check-shadowing: true
+  golint:
+    min-confidence: 0
+  gocyclo:
+    min-complexity: 15
+  maligned:
+    suggest-new: true
+
+  # gocritic has tons of checkers
+  # https://go-critic.github.io/overview#checks-overview
+  # gocritic:
+
+issues:
+  max-per-linter: 0
+  max-same-issues: 0
+  exclude-rules:
+    - path: ".*_test.go$"
+      text: "Using the variable on range scope `(tt|v)` in function literal"
+      linters:
+        - scopelint