fix: stop infinite rerenders by removing query from useEffect deps

[amcgee]

IMPORTANT FIX

A (sort of) bug was introduced in #34 - we started re-fetching whenever the query changed, but since many queries are object literals constructed within the render loop, their reference identity would actually change and cause an infinite loop of re-renders and re-fetches. @Mohammer5 noticed this in the new maintenance app.

The true "correct" solution might be to do a deep equality check on the query, but I think this is a good solution for now - we don't list query as a dep of useEffect, even though it technically is. This means nothing will happen if the query is updated after the hook is first run by the render method, which should be fine.

[amcgee]

Side note: our code style enforcement is too good - this breaks an eslint rule, so before I explicitly disabled that rule for this line cli-style silently undid my change precommit and turned the commit into a no-op

[dhis2-bot]

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[SferaDev]

@amcgee Query should be mutable or immutable by design?

Instead of a deep equality check, a ref could be used instead.

If mutable it just holds initial value inside and if mutable it updates the ref with actual value as a side effect.

And in the dependency array you can now safely use the ref as it won't change its object reference.

function Example(query) {
  const request = useRef(query);
  // If immutable just remove the side effect that updates
  useEffect(() => {
    request.current = query;
  });
}