fix: support independent data provider, refactor example#70
Merged
Conversation
Contributor
Author
|
I'm going to go ahead and merge this without review since it is a very small functional change and necessary to fix a bug live in production. |
dhis2-bot
pushed a commit
that referenced
this pull request
Aug 14, 2019
## [1.4.3](v1.4.2...v1.4.3) (2019-08-14) ### Bug Fixes * support independent data provider, refactor example ([#70](#70)) ([7db27f6](7db27f6))
Contributor
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
:-) thanks |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug introduced with #13 which caused the independently exposed DataProvider to ignore its parameters and fall back to the default Config values. This fixes that issue (one-line change) and also refactors the example to support testing of both configurations.