Conversation
|
Deploy preview for dhis2-app-runtime ready! Built with commit 61a9223 |
Contributor
Author
|
Maybe this should be a patch bump rather than a feature bump? |
varl
approved these changes
Sep 30, 2019
Contributor
varl
left a comment
varl
left a comment
There was a problem hiding this comment.
Code looks good to me.
I agree that it should be a patch bump.
amcgee
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Sep 30, 2019
## [2.0.2](v2.0.1...v2.0.2) (2019-09-30) ### Bug Fixes * add runtime query validation ([#160](#160)) ([a8d2d5e](a8d2d5e))
Contributor
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds runtime query and mutation validation to the Data Engine, rather than throwing an unrelated and unhelpful error (like
cannot read property 'startsWith' of undefinedif no "resource" property exists.