fix: update dependencies to get rid of d2 init warnings#1415
Merged
KaiVandivier merged 2 commits intomasterfrom Jul 8, 2025
Merged
fix: update dependencies to get rid of d2 init warnings#1415KaiVandivier merged 2 commits intomasterfrom
KaiVandivier merged 2 commits intomasterfrom
Conversation
kabaros
force-pushed
the
fix/d2-init-warnings
branch
from
9b26677 to
2141a71
Compare
KaiVandivier
reviewed
Jul 8, 2025
Comment on lines
+42
to
+43
| "react": "^16 || ^18", | ||
| "react-dom": "^16 || ^18" |
Contributor
There was a problem hiding this comment.
This PR mostly looks good!
My one comment is that I think it makes sense to keep the 16.8.6 floor for React -- 16.8.0 introduces hooks, so this library won't work with lower versions of v16
It's unlikely to be encountered, but technically correct I think 😅
the version where react hooks were introduced
|
KaiVandivier
approved these changes
Jul 8, 2025
dhis2-bot
added a commit
that referenced
this pull request
Jul 8, 2025
## [3.14.5](v3.14.4...v3.14.5) (2025-07-08) ### Bug Fixes * update dependencies to get rid of d2 init warnings ([#1415](#1415)) ([ec044f3](ec044f3))
Contributor
|
🎉 This PR is included in version 3.14.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes prop-types to a dependency rather than a peer dependency, similar to what we do in UI.
Implements https://dhis2.atlassian.net/browse/LIBS-771
related to dhis2/app-platform#927