Skip to content

fix: expand FetchErrorDetails type#1389

Merged
amcgee merged 2 commits intomasterfrom
error-details-type
Oct 14, 2024
Merged

fix: expand FetchErrorDetails type#1389
amcgee merged 2 commits intomasterfrom
error-details-type

Conversation

@KaiVandivier
Copy link
Copy Markdown
Contributor

@KaiVandivier KaiVandivier commented Oct 11, 2024 •
edited
Loading

Noticed when using error details here: https://github.com/dhis2/reference-civil-registry-lookup/blob/069d664aa7d3c653c8a46c050c8e61d75eb327b4/civil-registry-plugin/src/LookupField/LookupField.tsx#L69-L72

This type should be flexible since details can vary, but provide some autocomplete for common properties

Here's an example error.details from a Route mutation:

{
    httpStatus: 'Not Found',
    httpStatusCode: 404,
    status: 'ERROR',
    message: 'Route does-not-exist not found',
    errorCode: 'E1005',
}

Some error details just end up as {}, as in some GET 404 responses

@amcgee amcgee merged commit ff0ad60 into master Oct 14, 2024
@amcgee amcgee deleted the error-details-type branch October 14, 2024 09:45
dhis2-bot added a commit that referenced this pull request Oct 14, 2024
@dhis2-bot
chore(release): cut 3.11.2 [skip ci]
39186d3 
## [3.11.2](v3.11.1...v3.11.2) (2024-10-14)

### Bug Fixes

* expand FetchErrorDetails type ([#1389](#1389)) ([ff0ad60](ff0ad60))
@dhis2-bot
Copy link
Copy Markdown
Contributor

dhis2-bot commented Oct 14, 2024

🎉 This PR is included in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

KaiVandivier added a commit that referenced this pull request Nov 25, 2024
@KaiVandivier
fix: expand FetchErrorDetails type (#1389)
78ad0b3
KaiVandivier pushed a commit that referenced this pull request Nov 25, 2024
@dhis2-bot @KaiVandivier
chore(release): cut 3.11.2 [skip ci]
50a85ad 
* expand FetchErrorDetails type ([#1389](#1389)) ([ff0ad60](ff0ad60))
dhis2-bot added a commit that referenced this pull request Nov 26, 2024
@dhis2-bot
chore(release): cut 3.11.0-alpha.1 [skip ci]
691bd06 
# [3.11.0-alpha.1](v3.10.4-alpha.1...v3.11.0-alpha.1) (2024-11-26)

### Bug Fixes

* **cacheable-section:** synchronously flush recording state for UI consistency ([04bc604](04bc604))
* add endpoint to text plain matchers ([#1390](#1390)) ([de8fbec](de8fbec))
* expand FetchErrorDetails type ([#1389](#1389)) ([78ad0b3](78ad0b3))
* handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([bba9c23](bba9c23))
* **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([31562e9](31562e9))
* update plugin sizing definition ([#1383](#1383)) ([38c09b9](38c09b9))
* **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([9e22e88](9e22e88))
* **deps:** update cli-app-scripts for package/types race condition ([dee6795](dee6795))

### Features

* fixed dimensions efficiency ([#1386](#1386)) ([b56ad2d](b56ad2d))
* upgrade app-runtime React version to v18 ([#1387](#1387)) ([0e4a3d5](0e4a3d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabaros kabaros kabaros approved these changes

@d-rita d-rita Awaiting requested review from d-rita

+1 more reviewer

@amcgee amcgee amcgee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KaiVandivier @dhis2-bot @amcgee @kabaros