feat: use form-data for dataValues endpoints#1133
Merged
KaiVandivier merged 1 commit intomasterfrom Feb 26, 2022
Merged
Conversation
KaiVandivier
force-pushed
the
feat-formdata-for-data-values
branch
from
323017b to
24b4ce4
Compare
amcgee
suggested changes
Feb 26, 2022
Contributor
amcgee
left a comment
amcgee
left a comment
There was a problem hiding this comment.
Am I missing something or is this function not called anywhere?
Contributor
Author
|
It’s batched in with other matchers here: |
amcgee
approved these changes
Feb 26, 2022
Contributor
amcgee
left a comment
amcgee
left a comment
There was a problem hiding this comment.
Got it, thanks. I think we should generally avoid the import * pattern, for this reason, but that's a separate issue
dhis2-bot
added a commit
that referenced
this pull request
Feb 26, 2022
# [3.3.0](v3.2.9...v3.3.0) (2022-02-26) ### Features * use form-data for dataValues endpoints ([#1133](#1133)) ([a67b926](a67b926))
Contributor
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This facilitates some work in the Data Entry app: the
/api/dataValuesendpoint accepts either form-data or query params, but not JSON -- being able to send the data using thedataproperty of the query feels more semantic than sending it in the query params. Theapi/dataValues/fileendpoint needs to use form-data to send files.