fix(offline): return correct value from clearSensitiveCaches#1008
Merged
KaiVandivier merged 1 commit into2.xfrom Sep 16, 2021
Merged
Conversation
varl
approved these changes
Sep 16, 2021
KaiVandivier
deleted the
fix-return-correct-response-from-clearSensitiveCaches
branch
dhis2-bot
added a commit
that referenced
this pull request
Sep 16, 2021
## [2.12.1](v2.12.0...v2.12.1) (2021-09-16) ### Bug Fixes * **offline:** return correct value from clearSensitiveCaches ([#1008](#1008)) ([02c2c6c](02c2c6c))
Contributor
|
🎉 This PR is included in version 2.12.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
KaiVandivier
added a commit
that referenced
this pull request
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when clearSensitiveCaches didn't resolve to a relevant value,
caches.delete(key).then(() => undefined)was returned inPromise.allto satisfy typescript, but I forgot to remove theundefinedresolution when I copied in a refactor from the app platform that madeclearSensitiveCachesresolve to a boolean indicating if any caches were deleted. Fixed that and some tests so that it resolves to the right boolean 👍