Skip to content

Conversation

@prakash100198
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Oct 8, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@prakash100198 prakash100198 changed the base branch from main to release-candidate-v0.20.0 October 8, 2024 10:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@prakash100198 prakash100198 merged commit 4953506 into release-candidate-v0.20.0 Oct 8, 2024
7 of 10 checks passed
@prakash100198 prakash100198 deleted the bulk-cm-edit-fix branch October 8, 2024 11:13
vikramdevtron added a commit that referenced this pull request Oct 14, 2024
* initialise acd client (#5964)

* auth group fix (#5966)

* query params append fix (#5967)

* bluk edit cm and secret fix (#5968)

* removed the field cia (#5969)

* query fix (#5971)

* rollback fix (#5972)

* fix: copy container image version

* fix: cluster and env prod/non prod not propagated in notification event payload

* common-lib update

* error handling while creating github repo (#5978)

---------

Co-authored-by: ayu-devtron <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Rajeev Ranjan <[email protected]>
Co-authored-by: Ash-exp <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: prakhar katiyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants