Skip to content

Commit f9cee30

Browse files
authored
Merge pull request #182 from devtron-labs/azure-blob
ci log handling
2 parents 520ab03 + 7afa23e commit f9cee30

File tree

4 files changed

+242
-42
lines changed

4 files changed

+242
-42
lines changed

Gopkg.lock

Lines changed: 58 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/pipeline/CdHandler.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ type CdHandlerImpl struct {
5555
Logger *zap.SugaredLogger
5656
cdService CdWorkflowService
5757
cdConfig *CdConfig
58+
ciConfig *CiConfig
5859
userService user.UserService
5960
ciLogService CiLogService
6061
ciArtifactRepository repository.CiArtifactRepository
@@ -73,7 +74,8 @@ func NewCdHandlerImpl(Logger *zap.SugaredLogger, cdConfig *CdConfig, userService
7374
ciPipelineMaterialRepository pipelineConfig.CiPipelineMaterialRepository,
7475
pipelineRepository pipelineConfig.PipelineRepository,
7576
envRepository cluster.EnvironmentRepository,
76-
ciWorkflowRepository pipelineConfig.CiWorkflowRepository) *CdHandlerImpl {
77+
ciWorkflowRepository pipelineConfig.CiWorkflowRepository,
78+
ciConfig *CiConfig) *CdHandlerImpl {
7779
return &CdHandlerImpl{
7880
Logger: Logger,
7981
cdConfig: cdConfig,
@@ -86,6 +88,7 @@ func NewCdHandlerImpl(Logger *zap.SugaredLogger, cdConfig *CdConfig, userService
8688
envRepository: envRepository,
8789
pipelineRepository: pipelineRepository,
8890
ciWorkflowRepository: ciWorkflowRepository,
91+
ciConfig: ciConfig,
8992
}
9093
}
9194

@@ -326,9 +329,16 @@ func (impl *CdHandlerImpl) getLogsFromRepository(pipelineId int, cdWorkflow *pip
326329
WorkflowName: cdWorkflow.Name,
327330
//AccessKey: cdConfig,
328331
//SecretKet: cdWorkflow.CdPipeline.CiTemplate.DockerRegistry.AWSSecretAccessKey,
329-
Region: cdConfig.CdCacheRegion,
330-
LogsBucket: cdConfig.LogsBucket,
331-
LogsFilePath: cdWorkflow.LogLocation, // impl.cdConfig.DefaultBuildLogsKeyPrefix + "/" + cdWorkflow.Name + "/main.log", //TODO - fixme
332+
Region: cdConfig.CdCacheRegion,
333+
LogsBucket: cdConfig.LogsBucket,
334+
LogsFilePath: cdWorkflow.LogLocation, // impl.cdConfig.DefaultBuildLogsKeyPrefix + "/" + cdWorkflow.Name + "/main.log", //TODO - fixme
335+
CloudProvider: impl.ciConfig.CloudProvider,
336+
AzureBlobConfig: &AzureBlobConfig{
337+
Enabled: true,
338+
AccountName: impl.ciConfig.AzureAccountName,
339+
BlobContainer: impl.ciConfig.AzureBlobContainer,
340+
AccountKey: impl.ciConfig.AzureAccountKey,
341+
},
332342
}
333343
impl.Logger.Infow("s3 log req ", "req", cdLogRequest)
334344
oldLogsStream, cleanUp, err := impl.ciLogService.FetchLogs(cdLogRequest)

pkg/pipeline/CiHandler.go

Lines changed: 30 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -559,14 +559,21 @@ func (impl *CiHandlerImpl) getLogsFromRepository(pipelineId int, ciWorkflow *pip
559559
ciConfig.CiCacheRegion = impl.ciConfig.DefaultCacheBucketRegion
560560
}
561561
ciLogRequest := CiLogRequest{
562-
PipelineId: ciWorkflow.CiPipelineId,
563-
WorkflowId: ciWorkflow.Id,
564-
WorkflowName: ciWorkflow.Name,
565-
AccessKey: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSAccessKeyId,
566-
SecretKet: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSSecretAccessKey,
567-
Region: ciConfig.CiCacheRegion,
568-
LogsBucket: ciConfig.LogsBucket,
569-
LogsFilePath: impl.ciConfig.DefaultBuildLogsKeyPrefix + "/" + ciWorkflow.Name + "/main.log",
562+
PipelineId: ciWorkflow.CiPipelineId,
563+
WorkflowId: ciWorkflow.Id,
564+
WorkflowName: ciWorkflow.Name,
565+
AccessKey: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSAccessKeyId,
566+
SecretKet: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSSecretAccessKey,
567+
Region: ciConfig.CiCacheRegion,
568+
LogsBucket: ciConfig.LogsBucket,
569+
LogsFilePath: impl.ciConfig.DefaultBuildLogsKeyPrefix + "/" + ciWorkflow.Name + "/main.log",
570+
CloudProvider: impl.ciConfig.CloudProvider,
571+
AzureBlobConfig: &AzureBlobConfig{
572+
Enabled: true,
573+
AccountName: impl.ciConfig.AzureAccountName,
574+
BlobContainer: impl.ciConfig.AzureBlobContainer,
575+
AccountKey: impl.ciConfig.AzureAccountKey,
576+
},
570577
}
571578
oldLogsStream, cleanUp, err := impl.ciLogService.FetchLogs(ciLogRequest)
572579
if err != nil {
@@ -649,14 +656,21 @@ func (impl *CiHandlerImpl) GetHistoricBuildLogs(pipelineId int, workflowId int,
649656
ciConfig.LogsBucket = impl.ciConfig.DefaultBuildLogsBucket
650657
}
651658
ciLogRequest := CiLogRequest{
652-
PipelineId: ciWorkflow.CiPipelineId,
653-
WorkflowId: ciWorkflow.Id,
654-
WorkflowName: ciWorkflow.Name,
655-
AccessKey: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSAccessKeyId,
656-
SecretKet: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSSecretAccessKey,
657-
Region: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSRegion,
658-
LogsBucket: ciConfig.LogsBucket,
659-
LogsFilePath: ciWorkflow.LogLocation,
659+
PipelineId: ciWorkflow.CiPipelineId,
660+
WorkflowId: ciWorkflow.Id,
661+
WorkflowName: ciWorkflow.Name,
662+
AccessKey: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSAccessKeyId,
663+
SecretKet: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSSecretAccessKey,
664+
Region: ciWorkflow.CiPipeline.CiTemplate.DockerRegistry.AWSRegion,
665+
LogsBucket: ciConfig.LogsBucket,
666+
LogsFilePath: ciWorkflow.LogLocation,
667+
CloudProvider: impl.ciConfig.CloudProvider,
668+
AzureBlobConfig: &AzureBlobConfig{
669+
Enabled: true,
670+
AccountName: impl.ciConfig.AzureAccountName,
671+
BlobContainer: impl.ciConfig.AzureBlobContainer,
672+
AccountKey: impl.ciConfig.AzureAccountKey,
673+
},
660674
}
661675
logsFile, cleanUp, err := impl.ciLogService.FetchLogs(ciLogRequest)
662676
logs, err := ioutil.ReadFile(logsFile.Name())

0 commit comments

Comments
 (0)