Skip to content

Commit e93dab0

Browse files
committed
Revert "chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#3355)"
This reverts commit 73f1aa5.
1 parent 49fecd6 commit e93dab0

File tree

11 files changed

+48
-56
lines changed

11 files changed

+48
-56
lines changed

api/helm-app/HelmAppService.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ import (
44
"context"
55
"errors"
66
"fmt"
7-
"net/http"
8-
"reflect"
9-
"strconv"
10-
"strings"
11-
"time"
12-
137
"github.com/caarlos0/env/v6"
148
"github.com/devtron-labs/devtron/api/connector"
159
openapi "github.com/devtron-labs/devtron/api/helm-app/openapiClient"
@@ -29,12 +23,17 @@ import (
2923
util2 "github.com/devtron-labs/devtron/util"
3024
"github.com/devtron-labs/devtron/util/rbac"
3125
jsonpatch "github.com/evanphx/json-patch"
26+
"github.com/ghodss/yaml"
3227
"github.com/gogo/protobuf/proto"
3328
"github.com/tidwall/gjson"
3429
"github.com/tidwall/sjson"
3530
"go.opentelemetry.io/otel"
3631
"go.uber.org/zap"
37-
"sigs.k8s.io/yaml"
32+
"net/http"
33+
"reflect"
34+
"strconv"
35+
"strings"
36+
"time"
3837
)
3938

4039
type HelmAppService interface {

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ require (
1818
github.com/devtron-labs/common-lib v0.0.0-20230407072229-d4f665f5ca12
1919
github.com/devtron-labs/protos v0.0.0-20230503113602-282404f70fd2
2020
github.com/evanphx/json-patch v5.6.0+incompatible
21+
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
2122
github.com/go-pg/pg v6.15.1+incompatible
2223
github.com/go-resty/resty/v2 v2.7.0
2324
github.com/gogo/protobuf v1.3.2
@@ -121,7 +122,6 @@ require (
121122
github.com/fatih/camelcase v1.0.0 // indirect
122123
github.com/felixge/httpsnoop v1.0.3 // indirect
123124
github.com/fvbommel/sortorder v1.0.1 // indirect
124-
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32 // indirect
125125
github.com/go-errors/errors v1.0.1 // indirect
126126
github.com/go-git/gcfg v1.5.0 // indirect
127127
github.com/go-git/go-billy/v5 v5.3.1 // indirect

internal/util/ChartService.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,15 @@ import (
2121
"compress/gzip"
2222
"context"
2323
"fmt"
24-
24+
"github.com/devtron-labs/devtron/api/bean"
25+
"github.com/devtron-labs/devtron/internal/sql/repository"
26+
appStoreBean "github.com/devtron-labs/devtron/pkg/appStore/bean"
27+
//appStoreBean "github.com/devtron-labs/devtron/pkg/appStore/bean"
28+
chartRepoRepository "github.com/devtron-labs/devtron/pkg/chartRepo/repository"
29+
repository2 "github.com/devtron-labs/devtron/pkg/user/repository"
30+
"github.com/devtron-labs/devtron/util"
31+
"github.com/go-pg/pg"
32+
"go.opentelemetry.io/otel"
2533
"io/ioutil"
2634
"math/rand"
2735
"net/http"
@@ -32,19 +40,11 @@ import (
3240
"strings"
3341
"time"
3442

35-
"github.com/devtron-labs/devtron/api/bean"
36-
"github.com/devtron-labs/devtron/internal/sql/repository"
37-
appStoreBean "github.com/devtron-labs/devtron/pkg/appStore/bean"
38-
chartRepoRepository "github.com/devtron-labs/devtron/pkg/chartRepo/repository"
39-
repository2 "github.com/devtron-labs/devtron/pkg/user/repository"
40-
"github.com/devtron-labs/devtron/util"
41-
"github.com/go-pg/pg"
43+
"github.com/ghodss/yaml"
4244
dirCopy "github.com/otiai10/copy"
43-
"go.opentelemetry.io/otel"
4445
"go.uber.org/zap"
4546
"k8s.io/helm/pkg/chartutil"
4647
"k8s.io/helm/pkg/proto/hapi/chart"
47-
"sigs.k8s.io/yaml"
4848
)
4949

5050
type ChartWorkingDir string

internal/util/K8sUtil.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ import (
2323
error2 "errors"
2424
"flag"
2525
"fmt"
26-
"net/http"
27-
"os/user"
28-
"path/filepath"
29-
"strings"
30-
"time"
31-
3226
"github.com/argoproj/gitops-engine/pkg/utils/kube"
3327
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
3428
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
3529
"k8s.io/apimachinery/pkg/runtime/schema"
3630
"k8s.io/apimachinery/pkg/version"
31+
"net/http"
32+
"os/user"
33+
"path/filepath"
34+
"strings"
35+
"time"
3736

3837
"github.com/devtron-labs/authenticator/client"
38+
"github.com/ghodss/yaml"
3939
"go.uber.org/zap"
4040
batchV1 "k8s.io/api/batch/v1"
4141
v1 "k8s.io/api/core/v1"
@@ -47,7 +47,6 @@ import (
4747
v12 "k8s.io/client-go/kubernetes/typed/core/v1"
4848
"k8s.io/client-go/rest"
4949
"k8s.io/client-go/tools/clientcmd"
50-
"sigs.k8s.io/yaml"
5150
)
5251

5352
type K8sUtil struct {

pkg/appStore/deployment/fullMode/AppStoreDeploymentFullModeService.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ import (
2121
"context"
2222
"encoding/json"
2323
"fmt"
24-
"path"
25-
"regexp"
26-
"time"
27-
2824
"github.com/devtron-labs/devtron/api/bean"
2925
"github.com/devtron-labs/devtron/client/argocdServer"
3026
repository3 "github.com/devtron-labs/devtron/internal/sql/repository"
@@ -40,17 +36,20 @@ import (
4036
util3 "github.com/devtron-labs/devtron/util"
4137
"github.com/devtron-labs/devtron/util/argo"
4238
"github.com/go-pg/pg"
39+
"path"
40+
"regexp"
41+
"time"
4342

4443
"github.com/argoproj/argo-cd/v2/pkg/apiclient/application"
4544
repository2 "github.com/argoproj/argo-cd/v2/pkg/apiclient/repository"
4645
"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
4746
application2 "github.com/devtron-labs/devtron/client/argocdServer/application"
4847
"github.com/devtron-labs/devtron/client/argocdServer/repository"
4948
"github.com/devtron-labs/devtron/internal/util"
49+
"github.com/ghodss/yaml"
5050
"go.uber.org/zap"
5151
"k8s.io/helm/pkg/chartutil"
5252
"k8s.io/helm/pkg/proto/hapi/chart"
53-
"sigs.k8s.io/yaml"
5453
)
5554

5655
const (

pkg/appStore/deployment/tool/AppStoreDeploymentHelmService.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@ package appStoreDeploymentTool
33
import (
44
"context"
55
"errors"
6-
"net/http"
7-
"time"
8-
96
client "github.com/devtron-labs/devtron/api/helm-app"
107
openapi "github.com/devtron-labs/devtron/api/helm-app/openapiClient"
118
"github.com/devtron-labs/devtron/internal/constants"
@@ -15,10 +12,12 @@ import (
1512
"github.com/devtron-labs/devtron/pkg/appStore/deployment/repository"
1613
appStoreDiscoverRepository "github.com/devtron-labs/devtron/pkg/appStore/discover/repository"
1714
clusterRepository "github.com/devtron-labs/devtron/pkg/cluster/repository"
15+
"github.com/ghodss/yaml"
1816
"github.com/go-pg/pg"
1917
"go.opentelemetry.io/otel"
2018
"go.uber.org/zap"
21-
"sigs.k8s.io/yaml"
19+
"net/http"
20+
"time"
2221
)
2322

2423
type AppStoreDeploymentHelmService interface {

pkg/chart/ChartService.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import (
2222
"context"
2323
"encoding/json"
2424
"fmt"
25-
2625
"go.opentelemetry.io/otel"
2726

2827
"github.com/devtron-labs/devtron/internal/constants"
@@ -55,13 +54,13 @@ import (
5554
"github.com/devtron-labs/devtron/internal/sql/repository/pipelineConfig"
5655
"github.com/devtron-labs/devtron/internal/util"
5756
util2 "github.com/devtron-labs/devtron/util"
57+
"github.com/ghodss/yaml"
5858
"github.com/go-pg/pg"
5959
"github.com/juju/errors"
6060
"github.com/xeipuuv/gojsonschema"
6161
"go.uber.org/zap"
6262
"k8s.io/helm/pkg/chartutil"
6363
"k8s.io/helm/pkg/proto/hapi/chart"
64-
"sigs.k8s.io/yaml"
6564
)
6665

6766
type TemplateRequest struct {

pkg/chartRepo/ChartRepositoryService.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,26 @@ import (
2222
"encoding/json"
2323
"errors"
2424
"fmt"
25-
"io"
26-
"io/ioutil"
27-
"net/http"
28-
"net/url"
29-
"strings"
30-
"time"
31-
3225
"github.com/devtron-labs/devtron/internal/sql/repository"
3326
"github.com/devtron-labs/devtron/internal/util"
3427
chartRepoRepository "github.com/devtron-labs/devtron/pkg/chartRepo/repository"
3528
"github.com/devtron-labs/devtron/pkg/cluster"
3629
serverEnvConfig "github.com/devtron-labs/devtron/pkg/server/config"
3730
"github.com/devtron-labs/devtron/pkg/sql"
3831
util2 "github.com/devtron-labs/devtron/pkg/util"
32+
"github.com/ghodss/yaml"
3933
"github.com/google/uuid"
4034
"go.uber.org/zap"
35+
"io"
36+
"io/ioutil"
4137
"k8s.io/helm/pkg/getter"
4238
"k8s.io/helm/pkg/helm/environment"
4339
"k8s.io/helm/pkg/repo"
4440
"k8s.io/helm/pkg/version"
45-
"sigs.k8s.io/yaml"
41+
"net/http"
42+
"net/url"
43+
"strings"
44+
"time"
4645
)
4746

4847
// secret keys

pkg/chartRepo/ChartRepositoryService_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@ package chartRepo
22

33
import (
44
"encoding/json"
5-
"testing"
6-
75
"github.com/devtron-labs/devtron/internal/sql/repository"
86
"github.com/devtron-labs/devtron/internal/util"
7+
"github.com/ghodss/yaml"
98
"github.com/stretchr/testify/assert"
109
"github.com/stretchr/testify/mock"
11-
"sigs.k8s.io/yaml"
10+
"testing"
1211
)
1312

1413
type ChartRepositoryServiceMock struct {

pkg/gitops/GitOpsConfigService.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ import (
2121
"context"
2222
"encoding/json"
2323
"fmt"
24+
cluster3 "github.com/argoproj/argo-cd/v2/pkg/apiclient/cluster"
25+
cluster2 "github.com/devtron-labs/devtron/client/argocdServer/cluster"
26+
"github.com/devtron-labs/devtron/pkg/sql"
27+
util3 "github.com/devtron-labs/devtron/pkg/util"
28+
"github.com/devtron-labs/devtron/util/argo"
2429
"math/rand"
2530
"net/http"
2631
"net/url"
@@ -30,23 +35,18 @@ import (
3035
"strings"
3136
"time"
3237

33-
cluster3 "github.com/argoproj/argo-cd/v2/pkg/apiclient/cluster"
3438
bean2 "github.com/devtron-labs/devtron/api/bean"
3539
"github.com/devtron-labs/devtron/client/argocdServer"
36-
cluster2 "github.com/devtron-labs/devtron/client/argocdServer/cluster"
3740
"github.com/devtron-labs/devtron/internal/sql/repository"
3841
"github.com/devtron-labs/devtron/internal/util"
3942
"github.com/devtron-labs/devtron/pkg/cluster"
40-
"github.com/devtron-labs/devtron/pkg/sql"
41-
util3 "github.com/devtron-labs/devtron/pkg/util"
4243
util2 "github.com/devtron-labs/devtron/util"
43-
"github.com/devtron-labs/devtron/util/argo"
44+
"github.com/ghodss/yaml"
4445
"github.com/go-pg/pg"
4546
"github.com/microsoft/azure-devops-go-api/azuredevops"
4647
"github.com/xanzy/go-gitlab"
4748
"go.uber.org/zap"
4849
"k8s.io/apimachinery/pkg/api/errors"
49-
"sigs.k8s.io/yaml"
5050
)
5151

5252
type GitOpsConfigService interface {

0 commit comments

Comments
 (0)